Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ : add init and edit sub command plugin for component manager config file scaffolding #2944

Closed
wants to merge 1 commit into from
Closed

Conversation

laxmikantbpandhare
Copy link
Member

@laxmikantbpandhare laxmikantbpandhare commented Sep 15, 2022

Add init and edit sub command plugin for component manager config file scaffolding.

Current output for the command:

laxmikantbhaskarpandhare@lpandhar-mac v1alpha1 % kubebuilder init --plugins config.kubebuilder.io/v1-alpha
Generating config/manager/controller_manager_config.yaml file...
laxmikantbhaskarpandhare@lpandhar-mac v1alpha1 % tree
.
├── PROJECT
└── config
    └── manager
        └── controller_manager_config.yaml

2 directories, 2 files

Also, edit sub command is working

laxmikantbhaskarpandhare@lpandhar-mac test-scaffold-init % tree                                             
.
└── PROJECT

0 directories, 1 file
laxmikantbhaskarpandhare@lpandhar-mac test-scaffold-init % kubebuilder edit --plugins config.kubebuilder.io/v1-alpha
Generating Grafana manifests to visualize controller status...
laxmikantbhaskarpandhare@lpandhar-mac test-scaffold-init % tree
.
├── PROJECT
└── config
    └── manager
        └── controller_manager_config.yaml

2 directories, 2 files

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 15, 2022
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 15, 2022
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 9, 2022
…e scaffolding

enables edit subcommand

removed unused function and variable
@laxmikantbpandhare laxmikantbpandhare marked this pull request as ready for review October 9, 2022 21:30
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 9, 2022
@laxmikantbpandhare
Copy link
Member Author

/assign @pwittrock

Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple nits and one fmt.Println() statement seems to be out of place.

Other than that it looks good to me!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: laxmikantbpandhare
Once this PR has been reviewed and has the lgtm label, please ask for approval from pwittrock by writing /assign @pwittrock in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@laxmikantbpandhare laxmikantbpandhare closed this by deleting the head repository Oct 11, 2022
@laxmikantbpandhare
Copy link
Member Author

these got closed automatically as head of the my repo got deleted. I will raise PR once again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants