Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ deprecate flag component-config #2942

Closed
wants to merge 1 commit into from
Closed

✨ deprecate flag component-config #2942

wants to merge 1 commit into from

Conversation

laxmikantbpandhare
Copy link
Member

@laxmikantbpandhare laxmikantbpandhare commented Sep 14, 2022

this will fix one of the requirements from #2782

This fix will mark the flag component-config as deprecated and throw the warning to the user whenever user tries to use it.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 14, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: laxmikantbpandhare
Once this PR has been reviewed and has the lgtm label, please assign jmrodri for approval by writing /assign @jmrodri in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 14, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @laxmikantbpandhare. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 14, 2022
deprecate flag component-config

deprecate flag return value _
@camilamacedo86
Copy link
Member

HI @laxmikantbpandhare,

Before deprecating IMHO we need to have the solution which we will deprecate it for.
So, first, we need to create the plugin then we can go there and say we are deprecating this flag in favour of using the plugin. We also will need to update the tutorial to let users know that.

Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
Until we have the other solution in place

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2022
@laxmikantbpandhare
Copy link
Member Author

HI @laxmikantbpandhare,

Before deprecating IMHO we need to have the solution which we will deprecate it for. So, first, we need to create the plugin then we can go there and say we are deprecating this flag in favour of using the plugin. We also will need to update the tutorial to let users know that.

@camilamacedo86 - Yes, I am working on it and let it be on hold until we have a plugin for it.

@laxmikantbpandhare
Copy link
Member Author

HI @laxmikantbpandhare,
Before deprecating IMHO we need to have the solution which we will deprecate it for. So, first, we need to create the plugin then we can go there and say we are deprecating this flag in favor of using the plugin. We also will need to update the tutorial to let users know that.

@camilamacedo86 - Yes, I am working on it and let it be on hold until we have a plugin for it.

@camilamacedo86 - PR is ready for review - #2944

@laxmikantbpandhare
Copy link
Member Author

/assign @jmrodri

@laxmikantbpandhare laxmikantbpandhare closed this by deleting the head repository Oct 11, 2022
@laxmikantbpandhare
Copy link
Member Author

these got closed automatically as head of the my repo got deleted. I will raise PR once again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants