-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ deprecate flag component-config #2942
✨ deprecate flag component-config #2942
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: laxmikantbpandhare The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @laxmikantbpandhare. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
deprecate flag component-config deprecate flag return value _
Before deprecating IMHO we need to have the solution which we will deprecate it for. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
Until we have the other solution in place
@camilamacedo86 - Yes, I am working on it and let it be on |
@camilamacedo86 - PR is ready for review - #2944 |
/assign @jmrodri |
these got closed automatically as head of the my repo got deleted. I will raise PR once again. |
this will fix one of the requirements from #2782
This fix will mark the flag
component-config
as deprecated and throw the warning to the user whenever user tries to use it.