-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ deprecate flag component-config #3023
✨ deprecate flag component-config #3023
Conversation
Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: laxmikantbpandhare The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR will be on hold as its replacement plugin is not merged yet #3022 Please refer to this comment for more information: #2942 (comment) /hold |
@laxmikantbpandhare: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
func (p *createSubcommand) BindFlags(fs *pflag.FlagSet) { p.flagSet = fs } | ||
func (p *createSubcommand) BindFlags(fs *pflag.FlagSet) { | ||
p.flagSet = fs | ||
_ = fs.MarkDeprecated("component-config", "component-config flag will be deprecated in upcoming releases") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But we are deprecating when we use MarkDeprecated
.
That will result in for example this option no longer be doc in sdk docs when we run make generate to generate the docs.
We need to first provide the option to do the same without the flag ( via the plugin ) then, we deprecate and add here in the command something like use the --plugins=component-config/v1-alpha
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
Could you please rebase this one with master? Also, could you please ensure that in the message we clarify the reason as described in the docs into the above PR? |
this will fix one of the requirements from #2782
This fix will mark the flag component-config as deprecated and throw a warning to the user whenever a user tries to use it.