⚠️ deprecate component config and no longer able to ensure that it is functioning as intended #3442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
camilamacedo86
force-pushed
the
deprecate-component-config
branch
from
2c0d6b6
to
ae3d30e
Compare
camilamacedo86
force-pushed
the
deprecate-component-config
branch
from
ae3d30e
to
b097026
Compare
kkkkun
reviewed
Jun 9, 2023
| @@ -136,6 +136,5 @@ scaffold_test_project project-v3 --plugins="go/v3" | |||
| scaffold_test_project project-v4 --plugins="go/v4" | |||
| scaffold_test_project project-v4-multigroup --plugins="go/v4" | |||
| scaffold_test_project project-v4-declarative-v1 --plugins="go/v4,declarative" | |||
| scaffold_test_project project-v4-config --component-config --plugins="go/v4" | |||
There was a problem hiding this comment.
Should we change this to scaffold_test_project project-v4-config --plugins="go/v4" ? Just remove component-config
There was a problem hiding this comment.
this line scaffolds the sample under testdata with component config
So we are just removing here since we no longer need this scaffold
|
Hope to confirm again @Kavinjsir @varshaprasad96 |
There was a problem hiding this comment.
The changes look good to me. But, we may also have to deprecate/remove the following:
- Setting of component config flag:
kubebuilder/pkg/config/v3/config.go
Line 163 in 81f65c2
- Remove the option for setting the flag in kustomize plugin:
and
kubebuilder/pkg/plugins/common/kustomize/v1/init.go
Lines 103 to 107 in 81f65c2
Comment on lines
6
to
11
| The ComponentConfig has been deprecated in the Controller-Runtime since its version 0.15.0. [More info](https://github.com/kubernetes-sigs/controller-runtime/issues/895) | ||
| Moreover, it has undergone breaking changes and is no longer functioning as intended. | ||
| As a result, Kubebuilder, which heavily relies on the Controller Runtime, has also deprecated this feature, | ||
| no longer guaranteeing its functionality from version 3.11.0 onwards. You can find additional details on this issue [here](https://github.com/kubernetes-sigs/controller-runtime/issues/2370). | ||
|
|
||
| Please, be aware that it will force Kubebuilder remove this option in soon future release. |
There was a problem hiding this comment.
Suggested change
| The ComponentConfig has been deprecated in the Controller-Runtime since its version 0.15.0. [More info](https://github.com/kubernetes-sigs/controller-runtime/issues/895) | |
| Moreover, it has undergone breaking changes and is no longer functioning as intended. | |
| As a result, Kubebuilder, which heavily relies on the Controller Runtime, has also deprecated this feature, | |
| no longer guaranteeing its functionality from version 3.11.0 onwards. You can find additional details on this issue [here](https://github.com/kubernetes-sigs/controller-runtime/issues/2370). | |
| Please, be aware that it will force Kubebuilder remove this option in soon future release. | |
| The `ComponentConfig` feature has been deprecated in the controller-Runtime since its version of 0.15.0. [More info](https://github.com/kubernetes-sigs/controller-runtime/issues/895) | |
| Moreover, it has undergone breaking changes and is no longer functioning as intended. | |
| As a result, Kubebuilder, which heavily relies on Controller Runtime, has also deprecated this feature, and no longer guarantees to have its functionality from version 3.11.0 and above. You can find additional details on this [issue](https://github.com/kubernetes-sigs/controller-runtime/issues/2370). | |
| Please be aware that it will force Kubebuilder to remove this option in future release if controller-runtime decides to not support it further. | |
| Instead of using component-config, the [`Options`](https://github.com/kubernetes-sigs/controller-runtime/blob/e54088c8c7da82111b4508bdaf189c45d1344f00/pkg/manager/manager.go#L100) can be passed directly to the manager like below: | |
| ```go | |
| mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), manager.Options{ | |
| Scheme: scheme, | |
| Controller: config.Controller{ | |
| NeedLeaderElection: pointer.Bool(true), | |
| MaxConcurrentReconciles: 2, | |
| ... | |
| }, | |
| }) |
There was a problem hiding this comment.
The alternative is straight forward, hence added it here. It would be helpful to provide another approach if we are deprecating this one.
There was a problem hiding this comment.
@varshaprasad96 but the idea of the ComponentConfig is we are able to have an option to deploy the same solution (same code) with different config options per env. So, if we pass direct the Options in the manager (default behaviour) then it does not achieve the same goal. Right?
Therefore, should we really say that?
There was a problem hiding this comment.
Since passing of the configuration options through the config file s removed, the next alternative for it to pass it through manager.Options. The idea is letting the user pass all customizable options through manager instead of config file. Which is why it is the alternative to what we have currently.
We need not block this PR for the docs update, I can add that in a follow up.
Comment on lines
6
to
11
| The ComponentConfig has been deprecated in the Controller-Runtime since its version 0.15.0. [More info](https://github.com/kubernetes-sigs/controller-runtime/issues/895) | ||
| Moreover, it has undergone breaking changes and is no longer functioning as intended. | ||
| As a result, Kubebuilder, which heavily relies on the Controller Runtime, has also deprecated this feature, | ||
| no longer guaranteeing its functionality from version 3.11.0 onwards. You can find additional details on this issue [here](https://github.com/kubernetes-sigs/controller-runtime/issues/2370). | ||
|
|
||
| Please, be aware that it will force Kubebuilder remove this option in soon future release. |
There was a problem hiding this comment.
Suggested change
| The ComponentConfig has been deprecated in the Controller-Runtime since its version 0.15.0. [More info](https://github.com/kubernetes-sigs/controller-runtime/issues/895) | |
| Moreover, it has undergone breaking changes and is no longer functioning as intended. | |
| As a result, Kubebuilder, which heavily relies on the Controller Runtime, has also deprecated this feature, | |
| no longer guaranteeing its functionality from version 3.11.0 onwards. You can find additional details on this issue [here](https://github.com/kubernetes-sigs/controller-runtime/issues/2370). | |
| Please, be aware that it will force Kubebuilder remove this option in soon future release. | |
| The ComponentConfig has been deprecated in the Controller-Runtime since its version 0.15.0. [More info](https://github.com/kubernetes-sigs/controller-runtime/issues/895) | |
| Moreover, it has undergone breaking changes and is no longer functioning as intended. | |
| As a result, Kubebuilder, which heavily relies on the Controller Runtime, has also deprecated this feature, | |
| no longer guaranteeing its functionality from version 3.11.0 onwards. You can find additional details on this issue [here](https://github.com/kubernetes-sigs/controller-runtime/issues/2370). | |
| Please, be aware that it will force Kubebuilder remove this option soon in future releases. |
Comment on lines
6
to
11
| The ComponentConfig has been deprecated in the Controller-Runtime since its version 0.15.0. [More info](https://github.com/kubernetes-sigs/controller-runtime/issues/895) | ||
| Moreover, it has undergone breaking changes and is no longer functioning as intended. | ||
| As a result, Kubebuilder, which heavily relies on the Controller Runtime, has also deprecated this feature, | ||
| no longer guaranteeing its functionality from version 3.11.0 onwards. You can find additional details on this issue [here](https://github.com/kubernetes-sigs/controller-runtime/issues/2370). | ||
|
|
||
| Please, be aware that it will force Kubebuilder remove this option in soon future release. |
There was a problem hiding this comment.
Nit
Suggested change
| The ComponentConfig has been deprecated in the Controller-Runtime since its version 0.15.0. [More info](https://github.com/kubernetes-sigs/controller-runtime/issues/895) | |
| Moreover, it has undergone breaking changes and is no longer functioning as intended. | |
| As a result, Kubebuilder, which heavily relies on the Controller Runtime, has also deprecated this feature, | |
| no longer guaranteeing its functionality from version 3.11.0 onwards. You can find additional details on this issue [here](https://github.com/kubernetes-sigs/controller-runtime/issues/2370). | |
| Please, be aware that it will force Kubebuilder remove this option in soon future release. | |
| The ComponentConfig has been deprecated in the Controller-Runtime since its version 0.15.0. [More info](https://github.com/kubernetes-sigs/controller-runtime/issues/895) | |
| Moreover, it has undergone breaking changes and is no longer functioning as intended. | |
| As a result, Kubebuilder, which heavily relies on the Controller Runtime, has also deprecated this feature, | |
| no longer guaranteeing its functionality from version 3.11.0 onwards. You can find additional details on this issue [here](https://github.com/kubernetes-sigs/controller-runtime/issues/2370). | |
| Please, be aware that it will force Kubebuilder remove this option soon in future releases. |
Comment on lines
6
to
11
| The ComponentConfig has been deprecated in the Controller-Runtime since its version 0.15.0. [More info](https://github.com/kubernetes-sigs/controller-runtime/issues/895) | ||
| Moreover, it has undergone breaking changes and is no longer functioning as intended. | ||
| As a result, Kubebuilder, which heavily relies on the Controller Runtime, has also deprecated this feature, | ||
| no longer guaranteeing its functionality from version 3.11.0 onwards. You can find additional details on this issue [here](https://github.com/kubernetes-sigs/controller-runtime/issues/2370). | ||
|
|
||
| Please, be aware that it will force Kubebuilder remove this option in soon future release. |
There was a problem hiding this comment.
Suggested change
| The ComponentConfig has been deprecated in the Controller-Runtime since its version 0.15.0. [More info](https://github.com/kubernetes-sigs/controller-runtime/issues/895) | |
| Moreover, it has undergone breaking changes and is no longer functioning as intended. | |
| As a result, Kubebuilder, which heavily relies on the Controller Runtime, has also deprecated this feature, | |
| no longer guaranteeing its functionality from version 3.11.0 onwards. You can find additional details on this issue [here](https://github.com/kubernetes-sigs/controller-runtime/issues/2370). | |
| Please, be aware that it will force Kubebuilder remove this option in soon future release. | |
| The ComponentConfig has been deprecated in the Controller-Runtime since its version 0.15.0. [More info](https://github.com/kubernetes-sigs/controller-runtime/issues/895) | |
| Moreover, it has undergone breaking changes and is no longer functioning as intended. | |
| As a result, Kubebuilder, which heavily relies on the Controller Runtime, has also deprecated this feature, | |
| no longer guaranteeing its functionality from version 3.11.0 onwards. You can find additional details on this issue [here](https://github.com/kubernetes-sigs/controller-runtime/issues/2370). | |
| Please, be aware that it will force Kubebuilder remove this option soon in future releases. |
… functioning as intended
camilamacedo86
force-pushed
the
deprecate-component-config
branch
from
b097026
to
da3322d
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, kkkkun, varshaprasad96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The ComponentConfig has been deprecated in the Controller-Runtime since its version 0.15.0. More info
Moreover, it has undergone breaking changes and is no longer functioning as intended.
As a result, Kubebuilder, which heavily relies on the Controller Runtime, has also deprecated this feature,
no longer guaranteeing its functionality from version 3.11.0 onwards. You can find additional details on this issue here.
Please, be aware that it will force Kubebuilder remove this option in soon future release.
Motivation
Bump Controller Runtime v0.15.0 and add support for k8s 1.27