📖 Fixed manager_webhook_patch not uncommented

[lauchokyip]

Fixes #3426

[k8s-ci-robot]

Hi @lauchokyip. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[camilamacedo86]

/ok-to-test

[manavrajvanshi]

Since you've already made the changes in the file hack/docs/internal/cronjob-tutorial/generate_cronjob.go, do we really need the change here in this file? Asking because this will by overwritten by make generate (and hence make generate-docs) as mentioned by @camilamacedo86 .

[lauchokyip]

The CI will run make generate that's why this file is included as part of the changes.

[manavrajvanshi]

As I understand, make generate will overwrite the file docs/book/src/cronjob-tutorial/testdata/project/config/default/kustomization.yaml, right?

If so, then do we explicitly need to make this change here? Else, this can be skipped. Thanks!

[lauchokyip]

make generate will generate the file, that's why changes need to be done in hack/docs/internal/cronjob-tutorial/generate_cronjob.go.

Once changes are made over there, I just run make generate and docs/book/src/cronjob-tutorial/testdata/project/config/default/kustomization.yaml was automatically been changed.

The CI will run make generate and compare with the PR, and therefore it will fail if I didn't run make generate before submitting the PR

[lauchokyip]

Please take a look at https://github.com/kubernetes-sigs/kubebuilder/actions/runs/5059859019/jobs/9085111581?pr=3427 for the Verify docs session

[camilamacedo86]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, lauchokyip, manavrajvanshi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[manavrajvanshi]

@camilamacedo86 , I see the issue I reported has been closed since this PR has been merged. Just curious to know how long does it take for the changes to reflect on the Kubebuilder book?
Asking because I still see the comment #- manager_webhook_patch.yaml.