Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Fixed manager_webhook_patch not uncommented #3427
📖 Fixed manager_webhook_patch not uncommented #3427
Changes from all commits
c9629c4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you've already made the changes in the file
hack/docs/internal/cronjob-tutorial/generate_cronjob.go
, do we really need the change here in this file? Asking because this will by overwritten bymake generate
(and hence make generate-docs) as mentioned by @camilamacedo86 .There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI will run
make generate
that's why this file is included as part of the changes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I understand,
make generate
will overwrite the filedocs/book/src/cronjob-tutorial/testdata/project/config/default/kustomization.yaml
, right?If so, then do we explicitly need to make this change here? Else, this can be skipped. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make generate
will generate the file, that's why changes need to be done inhack/docs/internal/cronjob-tutorial/generate_cronjob.go
.Once changes are made over there, I just run
make generate
anddocs/book/src/cronjob-tutorial/testdata/project/config/default/kustomization.yaml
was automatically been changed.The CI will run
make generate
and compare with the PR, and therefore it will fail if I didn't runmake generate
before submitting the PRThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at https://github.com/kubernetes-sigs/kubebuilder/actions/runs/5059859019/jobs/9085111581?pr=3427 for the
Verify docs
session