-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Simplify if condition in cronjob tutorial #3765
Conversation
|
Welcome @lpugoy! |
Hi @lpugoy. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lpugoy
When we do changes we need to run make generate
(you can check the Makefile and the Contributing.md guide)
Make generate will re-generated the docs and samples under the testdata dir.
Therefore, this changes must be done in the logic that we use to update it. That means, here: https://github.com/kubernetes-sigs/kubebuilder/tree/master/hack/docs/internal/cronjob-tutorial
So, can you please:
- Update the hack/docs with your change
- Run
make generate
- Squash the commits and push it
So, that we can get it merged.
Thank you 🥇
Sorry for that @camilamacedo86. I have fixed the changes and run The Contributing.md guide also mentioned that I should submit an issue. Should I do that as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approved
Hi @lpugoy
Thank you and all fine. However, see that it is falling because your branch is not rebased with master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/lgtm
/approved
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, lpugoy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you for your patience @camilamacedo86 . |
hi @lpugoy |
Simplify if condition in cronjob tutorial
In the "Writing tests" section of the cronjob tutorial, the following code
can be simplified to