📖 Simplify if condition in cronjob tutorial (kubernetes-sigs#3765)

Simplify if condition in cronjob tutorial
sarthaksarthak9 · Feb 25, 2024 · c9c1f88 · c9c1f88
1 parent a2ff78f
commit c9c1f88
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/...book/src/cronjob-tutorial/testdata/project/internal/controller/cronjob_controller_test.go b/...book/src/cronjob-tutorial/testdata/project/internal/controller/cronjob_controller_test.go
@@ -115,10 +115,7 @@ var _ = Describe("CronJob controller", func() {
 			// We'll need to retry getting this newly created CronJob, given that creation may not immediately happen.
 			Eventually(func() bool {
 				err := k8sClient.Get(ctx, cronjobLookupKey, createdCronjob)
-				if err != nil {
-					return false
-				}
-				return true
+				return err == nil
 			}, timeout, interval).Should(BeTrue())
 			// Let's make sure our Schedule string value was properly converted/handled.
 			Expect(createdCronjob.Spec.Schedule).Should(Equal("1 * * * *"))

diff --git a/hack/docs/internal/cronjob-tutorial/writing_tests_controller.go b/hack/docs/internal/cronjob-tutorial/writing_tests_controller.go
@@ -134,10 +134,7 @@ var _ = Describe("CronJob controller", func() {
 			// We'll need to retry getting this newly created CronJob, given that creation may not immediately happen.
 			Eventually(func() bool {
 				err := k8sClient.Get(ctx, cronjobLookupKey, createdCronjob)
-				if err != nil {
-					return false
-				}
-				return true
+				return err == nil
 			}, timeout, interval).Should(BeTrue())
 			// Let's make sure our Schedule string value was properly converted/handled.
 			Expect(createdCronjob.Spec.Schedule).Should(Equal("1 * * * *"))