Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various problems with hardcoded values in the vSphere Terraform code #8176

Closed
llarsson opened this issue Nov 10, 2021 · 1 comment · Fixed by #8178
Closed

Fix various problems with hardcoded values in the vSphere Terraform code #8176

llarsson opened this issue Nov 10, 2021 · 1 comment · Fixed by #8178
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@llarsson
Copy link
Contributor

What would you like to be added: the vSphere Terraform code has various issues, like hardcoded values, which makes it difficult to use for deployment.

Why is this needed: any vSphere deployment will need to actually take the variables into account, not rely on hardcoded values.
@llarsson llarsson added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 10, 2021
@llarsson
Copy link
Contributor Author

I volunteer as tribute. 😄

No, but seriously, I will make a pull request with the needed changes.

@llarsson llarsson mentioned this issue Nov 10, 2021
Merged
k8s-ci-robot pushed a commit that referenced this issue Nov 12, 2021
@llarsson
Fixes various issues in vSphere Terraform code (#8178)
6eeb488 
* Fixes various issues in vSphere Terraform code

Provided to address various shortcomings and to fix the following
issue in upstream Kubespray:

#8176

* Resolves Terraform formatting issues

* Sets default prefix to human-readable name

* Documents new default prefix in README
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this issue Apr 16, 2022
@llarsson @sakuraiyuta
Fixes various issues in vSphere Terraform code (kubernetes-sigs#8178)
42016f0 
* Fixes various issues in vSphere Terraform code

Provided to address various shortcomings and to fix the following
issue in upstream Kubespray:

kubernetes-sigs#8176

* Resolves Terraform formatting issues

* Sets default prefix to human-readable name

* Documents new default prefix in README
LuckySB pushed a commit to southbridgeio/kubespray that referenced this issue Jun 28, 2023
@llarsson @LuckySB
Fixes various issues in vSphere Terraform code (kubernetes-sigs#8178)
47f9bf5 
* Fixes various issues in vSphere Terraform code

Provided to address various shortcomings and to fix the following
issue in upstream Kubespray:

kubernetes-sigs#8176

* Resolves Terraform formatting issues

* Sets default prefix to human-readable name

* Documents new default prefix in README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes various issues in vSphere Terraform code
1 participant
@llarsson