Fixes various issues in vSphere Terraform code

[llarsson]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it: fixes hardcoded in the Terraform code for vSphere, which caused configured variables to be ignored.

Which issue(s) this PR fixes:

Fixes #8176

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[vSphere] Terraform code now documents and requires specification of the OVF template to use and separate specification of the netmask to use.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @llarsson!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @llarsson. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[llarsson]

Commenting here in the hopes of having the company's CLA show up correctly. 😄

Also, the pipeline has failed, but the failing build step seems to be fine and also the artifact is empty?

[llarsson]

@bozzo and/or @oomichi: please help me understand where to go from here, given that the pipeline failure does not provide me with any useful information as far as I can see. 🤔

[floryut]

@bozzo and/or @oomichi: please help me understand where to go from here, given that the pipeline failure does not provide me with any useful information as far as I can see. 🤔

fmt 😉

$ terraform -chdir="contrib/terraform/$PROVIDER" fmt -check -diff
default.tfvars
--- old/default.tfvars
+++ new/default.tfvars
@@ -8,17 +8,17 @@
   "master-0" : {
     "node_type" : "master",
     "ip" : "i-did-not-read-the-docs", # e.g. 192.168.0.10
-    "netmask": "24"
+    "netmask" : "24"
   },
   "worker-0" : {
     "node_type" : "worker",
     "ip" : "i-did-not-read-the-docs", # e.g. 192.168.0.20
-    "netmask": "24"
+    "netmask" : "24"
   },
   "worker-1" : {
     "node_type" : "worker",
     "ip" : "i-did-not-read-the-docs", # e.g. 192.168.0.21
-    "netmask": "24"
+    "netmask" : "24"
   }
 }

[oomichi]

Yes, you are right.
It is necessary to fix the format as https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/1768111609

[llarsson]

Embarrassing that formatting was all it took. The pipeline seems to fail in a rather unexpected way, to me. Is the failing step really vSphere related?

[oomichi]

Embarrassing that formatting was all it took. The pipeline seems to fail in a rather unexpected way, to me. Is the failing step really vSphere related?

Yeah, the failure is unrelated and the pipeline is kicked again.
Let's see the result.

/ok-to-test

[floryut]

@llarsson Thanks for the PR ! Please check @oomichi comments and then we'll merge 👍

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, llarsson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• contrib/terraform/OWNERS [floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[oomichi]

Thanks for updating again.

/lgtm