Only deploy container engine if needed on etcd nodes #7532

VannTen · 2021-04-20T10:33:57Z

What type of PR is this?
/kind bug

What this PR does / why we need it:

If the etcd cluster is separate and the etcd_deployment_type is "host",
there is no need for a container engine on the etcd nodes

Which issue(s) this PR fixes:

Fixes #7314
The issue was closed by its author, but it is not solved

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Container engine is no longer installed on separate etcd nodes when using
`etcd_deployment_type: host`

k8s-ci-robot · 2021-04-20T10:34:00Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2021-04-20T10:34:05Z

Welcome @VannTen!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2021-04-20T10:34:05Z

Hi @VannTen. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

champtar · 2021-04-22T13:53:23Z

cluster.yml

+        - deploy_container_engine|default(true)
+        - etcd_deployment_type != "host" or "k8s-cluster" in group_names


I think you should define deploy_container_engine in roles/kubespray-defaults/defaults/main.yaml, because deploy_container_engine is used at multiple locations
something like

deploy_container_engine: etcd_deployment_type != "host" or inventory_hostname in groups['kube-cluster']

VannTen · 2021-04-22T15:35:51Z

With the current state (of this PR), it's impossible to override it for external etcd nodes using the host method. If I'm correct, using the default would make it possible. (Correct me if I'm mistaken). Should it be ? (possible, I mean). I don't see a case where kubespray should do it, but I may have missed some use cases. I'll defer to your opinion on that. By the way, regardless of the path which will be chosen, I realized I'll need to update the other location where the role is imported with that check.

champtar · 2021-04-22T20:36:56Z

My point is don't update all the locations at all and just define deploy_container_engine in roles/kubespray-defaults/defaults/main.yaml
Also you need to sign the CLA ;)

VannTen · 2021-04-23T08:09:57Z

I modified the pr according to this.
I updated the (not that many) location which were using the 'default(true)',
since it does not make sense to have it if we define the default in
kubespray-defaults.

I got your point, but mine was that the behavior is slighly different.

Regarding the CLA, I need a CCLA (I'm doing this on company time), and I've
asked my management if we already have one or need to do the sign up.

champtar · 2021-04-23T11:03:47Z

roles/kubespray-defaults/defaults/main.yaml

@@ -230,6 +230,9 @@ kube_api_aggregator_routing: false
 # Profiling
 kube_profiling: false

+# Whether to deploy the container engine
+deploy_container_engine: inventory_hostname in groups['k8s-cluster'] or etcd_deployment_type != 'host'


now that I see it I have a doubt ...

Suggested change

deploy_container_engine: inventory_hostname in groups['k8s-cluster'] or etcd_deployment_type != 'host'

deploy_container_engine: {{ inventory_hostname in groups['k8s-cluster'] or etcd_deployment_type != 'host' }}

Is it fine to skip this @champtar point?

Anyways we need to replace k8s-cluster with k8s_cluster because of the commit 360aff4

Is it fine to skip this @champtar point?

Boolean can be evaluated directly can't they (in yaml ansible I mean) ?

I'll update with the new group name

I have a problem while upgrading the etcd in #8381 so I trying to debug by printing out the value of deploy_container_engine

ansible.builtin.debug: msg: "deploy_container_engine={{ deploy_container_engine }} host={{ inventory_hostname }}, etcd={{ etcd_deployment_type }}

TASK [deploy_container_engine] ok: [callisto-e3] => { "msg": "deploy_container_engine=inventory_hostname in groups['k8s_cluster'] or etcd_deployment_type != 'host' host=callisto-e3, etcd=host" }

It's turn out that the variable is literally a string from kubespray/roles/kubespray-defaults/defaults/main.yaml so it evaluated as True in { role: container-engine, tags: "container-engine", when: deploy_container_engine } and cause the container-engine role to run

After I apply a fix in #8386 the value is now boolean as expected and the problem solved.

TASK [deploy_container_engine] ok: [callisto-e1] => { "msg": "deploy_container_engine=False host=callisto-e1, etcd=host" }

VannTen · 2021-04-23T11:15:17Z

now that I see it I have a doubt ... ```suggestion deploy_container_engine: {{ inventory_hostname in groups['k8s-cluster'] or etcd_deployment_type != 'host' }} ```

Well, that would need quotes around the brackets. But I don't think we need to interpolate here ?

champtar · 2021-08-11T18:44:36Z

@VannTen any progress on the CLA signing ?

champtar · 2021-08-11T19:18:18Z

That answers the CLA signing question, still need rebase

VannTen · 2021-08-23T09:42:09Z

I'll do that.

VannTen · 2021-09-08T12:52:53Z

Is there anything missing from my side to proceed ?

floryut · 2021-09-08T13:49:52Z

Is there anything missing from my side to proceed ?

I've restarted tests as there was a temp issue with the CI on your PR

floryut · 2021-09-09T12:48:16Z

/cc @champtar
All good for you ?

floryut · 2021-09-24T09:34:46Z

/cc @champtar @oomichi

If the etcd cluster is separate and the etcd_deployment_type is "host", there is no need for a container engine on the etcd nodes Do not rely on a 'default(true)' filter, but define a proper default in kubespray-defaults depending on etcd deployment method and if internal or external etcd is used

VannTen · 2021-10-11T19:39:11Z

I've updated the PR to use the new naming scheme. The failing job does not seem related to me (certificate problem). Is there anything missing from my side ?

floryut · 2021-10-12T06:54:14Z

I've updated the PR to use the new naming scheme. The failing job does not seem related to me (certificate problem). Is there anything missing from my side ?

Yes the CI issue is linked to something else, that'll be soon fixed on master branch.
And regarding your PR, nothing, only time from reviewers to drop a lgtm on it 😄

champtar · 2021-10-12T07:26:17Z

/lgtm

floryut

/ok-to-test

k8s-ci-robot · 2021-10-12T07:30:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

If the etcd cluster is separate and the etcd_deployment_type is "host", there is no need for a container engine on the etcd nodes Do not rely on a 'default(true)' filter, but define a proper default in kubespray-defaults depending on etcd deployment method and if internal or external etcd is used

k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 20, 2021

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 20, 2021

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 20, 2021

k8s-ci-robot requested review from bozzo and EppO April 20, 2021 10:34

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 20, 2021

champtar suggested changes Apr 22, 2021

View reviewed changes

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 23, 2021

champtar reviewed Apr 23, 2021

View reviewed changes

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 28, 2021

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 11, 2021

VannTen force-pushed the master branch from 9c071fb to aa84325 Compare August 23, 2021 09:43

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 23, 2021

VannTen requested a review from champtar August 23, 2021 13:40

k8s-ci-robot requested a review from oomichi September 24, 2021 09:34

VannTen force-pushed the master branch from aa84325 to 006002b Compare October 7, 2021 09:18

k8s-ci-robot assigned champtar Oct 12, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2021

floryut added kind/container-managers Containers section in the release note and removed kind/bug Categorizes issue or PR as related to a bug. labels Oct 12, 2021

floryut approved these changes Oct 12, 2021

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 12, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2021

k8s-ci-robot merged commit e4c8c71 into kubernetes-sigs:master Oct 12, 2021

VannTen mentioned this pull request Oct 20, 2021

Docker is installed on the etcd nodes. even though I set etcd_deployment_type: host #7987

Closed

floryut mentioned this pull request Dec 21, 2021

Release Proposal v2.18 #8325

Closed

This was referenced Jan 6, 2022

Dedicated etcd upgrade failed to upgrade from 2.17 (role: container-engine) #8381

Closed

Fix container engine still installed on dedicated etcd node even if etcd_deployment_type: host #8386

Merged

VannTen mentioned this pull request Nov 28, 2023

REQUEST: New membership for VannTen kubernetes/org#4607

Closed

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Only deploy container engine if needed on etcd nodes #7532

Only deploy container engine if needed on etcd nodes #7532

VannTen commented Apr 20, 2021

k8s-ci-robot commented Apr 20, 2021

k8s-ci-robot commented Apr 20, 2021

k8s-ci-robot commented Apr 20, 2021

champtar Apr 22, 2021

VannTen commented Apr 22, 2021 via email •

edited

Loading

champtar commented Apr 22, 2021

VannTen commented Apr 23, 2021

champtar Apr 23, 2021

oomichi Oct 4, 2021

VannTen Oct 7, 2021 •

edited

Loading

rtsp Jan 6, 2022

VannTen commented Apr 23, 2021 via email

champtar commented Aug 11, 2021

champtar commented Aug 11, 2021

VannTen commented Aug 23, 2021

VannTen commented Sep 8, 2021

floryut commented Sep 8, 2021

floryut commented Sep 9, 2021

floryut commented Sep 24, 2021

VannTen commented Oct 11, 2021

floryut commented Oct 12, 2021

champtar commented Oct 12, 2021

floryut left a comment

k8s-ci-robot commented Oct 12, 2021

		- deploy_container_engine\|default(true)
		- etcd_deployment_type != "host" or "k8s-cluster" in group_names

	deploy_container_engine: inventory_hostname in groups['k8s-cluster'] or etcd_deployment_type != 'host'
	deploy_container_engine: {{ inventory_hostname in groups['k8s-cluster'] or etcd_deployment_type != 'host' }}

Only deploy container engine if needed on etcd nodes #7532

Only deploy container engine if needed on etcd nodes #7532

Conversation

VannTen commented Apr 20, 2021

k8s-ci-robot commented Apr 20, 2021

k8s-ci-robot commented Apr 20, 2021

k8s-ci-robot commented Apr 20, 2021

champtar Apr 22, 2021

Choose a reason for hiding this comment

VannTen commented Apr 22, 2021 via email • edited Loading

champtar commented Apr 22, 2021

VannTen commented Apr 23, 2021

champtar Apr 23, 2021

Choose a reason for hiding this comment

oomichi Oct 4, 2021

Choose a reason for hiding this comment

VannTen Oct 7, 2021 • edited Loading

Choose a reason for hiding this comment

rtsp Jan 6, 2022

Choose a reason for hiding this comment

VannTen commented Apr 23, 2021 via email

champtar commented Aug 11, 2021

champtar commented Aug 11, 2021

VannTen commented Aug 23, 2021

VannTen commented Sep 8, 2021

floryut commented Sep 8, 2021

floryut commented Sep 9, 2021

floryut commented Sep 24, 2021

VannTen commented Oct 11, 2021

floryut commented Oct 12, 2021

champtar commented Oct 12, 2021

floryut left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Oct 12, 2021

VannTen commented Apr 22, 2021 via email •

edited

Loading

VannTen Oct 7, 2021 •

edited

Loading