Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix container engine still installed on dedicated etcd node even if etcd_deployment_type: host #8386

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Fix container engine still installed on dedicated etcd node even if etcd_deployment_type: host #8386

merged 1 commit into from
Jan 10, 2022

Conversation

rtsp
Copy link
Member

@rtsp rtsp commented Jan 6, 2022 •
edited
Loading

What type of PR is this?
/kind bug

What this PR does / why we need it:
Missing a bracket {{ ... }} in #7532 cause the deploy_container_engine to parse as a string instead of conditional logic.

Which issue(s) this PR fixes:
Fixes #8381 #7987

Special notes for your reviewer:

  • This fix should also backport to release-2.18
  • Look like there's no CI test for dedicated etcd?

Does this PR introduce a user-facing change?:

Fix container engine still installed on dedicated etcd node even if `etcd_deployment_type: host`

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 6, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @rtsp. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 6, 2022
@rtsp rtsp marked this pull request as ready for review January 6, 2022 18:47
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 6, 2022
@rtsp rtsp changed the title Fix incorrect syntax for deploy_container_engine variable Fix container engine still installed on dedicated etcd node even if etcd_deployment_type: host Jan 6, 2022
@rtsp rtsp force-pushed the 8381-dedicated-etcd-upgrade-failed branch from 01d2751 to 04f598d Compare January 6, 2022 18:51
@rtsp rtsp mentioned this pull request Jan 6, 2022
Merged
@cristicalin
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 9, 2022
@cristicalin
Copy link
Contributor

Looks good @rtsp !

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2022
floryut
floryut approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rtsp wow 🤦 thanks 👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, rtsp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit aa4a3d7 into kubernetes-sigs:master Jan 10, 2022
rtsp added a commit to rtsp/kubespray that referenced this pull request Jan 10, 2022
@rtsp
* Fix container engine still installed on dedicated etcd node even if…
cda8776 
… `etcd_deployment_type: host` (kubernetes-sigs#8386)

(cherry picked from commit aa4a3d7)
rtsp added a commit to rtsp/kubespray that referenced this pull request Jan 10, 2022
@rtsp
[2.18] Fix container engine still installed on dedicated etcd
11ca654 
* Fix container engine still installed on dedicated etcd node even if `etcd_deployment_type: host` (kubernetes-sigs#8386)

(cherry picked from commit aa4a3d7)
@rtsp rtsp mentioned this pull request Jan 11, 2022
Merged
k8s-ci-robot pushed a commit that referenced this pull request Jan 11, 2022
@rtsp
[2.18] Fix container engine still installed on dedicated etcd (#8404)
8a3c78e 
* Fix container engine still installed on dedicated etcd node even if `etcd_deployment_type: host` (#8386)

(cherry picked from commit aa4a3d7)
This was referenced Jan 15, 2022
Closed
Closed
@rtsp rtsp deleted the 8381-dedicated-etcd-upgrade-failed branch April 12, 2022 13:33
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
@rtsp @sakuraiyuta
Fix container engine still installed on dedicated etcd node even if `…
aa2220a 
…etcd_deployment_type: host` (kubernetes-sigs#8386)
@oomichi oomichi mentioned this pull request May 28, 2022
Closed
huangkevin404 pushed a commit to wiremind/kubespray that referenced this pull request Sep 15, 2022
@rtsp
[2.18] Fix container engine still installed on dedicated etcd (kubern…
b8cfa52 
…etes-sigs#8404)

* Fix container engine still installed on dedicated etcd node even if `etcd_deployment_type: host` (kubernetes-sigs#8386)

(cherry picked from commit aa4a3d7)
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 29, 2023
@rtsp @LuckySB
Fix container engine still installed on dedicated etcd node even if `…
1185e01 
…etcd_deployment_type: host` (kubernetes-sigs#8386)
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 20, 2023
@rtsp @LuckySB
Fix container engine still installed on dedicated etcd node even if `…
84cf03f 
…etcd_deployment_type: host` (kubernetes-sigs#8386)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@holmsten holmsten Awaiting requested review from holmsten

@jayonlau jayonlau Awaiting requested review from jayonlau

Assignees

@cristicalin cristicalin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dedicated etcd upgrade failed to upgrade from 2.17 (role: container-engine)
4 participants
@rtsp @k8s-ci-robot @cristicalin @floryut