-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove extra parameter kube_proxy_remove #8158
Conversation
Welcome @EDGsheryl! |
Hi @EDGsheryl. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@EDGshery please rebase on latest master branch to make the CI happy (see #8157) |
/retest |
@EDGsheryl: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sure, thanks. |
Signed-off-by: EDGsheryl <edgsheryl@gmail.com>
Thanks for the fix @EDGsheryl ! /ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EDGsheryl, floryut The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: EDGsheryl <edgsheryl@gmail.com>
Signed-off-by: EDGsheryl edgsheryl@gmail.com
What type of PR is this?
/kind bug
/kind cleanup
/kind documentation
What this PR does / why we need it:
I noticed that the runbook failed when I enable the
calico_bpf_enabled
, so I trace the issue, I found that #6512 had removed the kube_proxy_remove, but it still exist in the runbook, so I clean it up.Which issue(s) this PR fixes:
Fixes #8149
Special notes for your reviewer:
Does this PR introduce a user-facing change?: