Skip to content

Commit

Permalink
Remove extra parameter kube_proxy_remove (kubernetes-sigs#8158)
Browse files Browse the repository at this point in the history
Signed-off-by: EDGsheryl <edgsheryl@gmail.com>
  • Loading branch information
EDGsheryl authored and sakuraiyuta committed Apr 16, 2022
1 parent 4669f66 commit f906163
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 12 deletions.
1 change: 0 additions & 1 deletion docs/calico.md
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,6 @@ To enable the eBPF dataplane support ensure you add the following to your invent

```yaml
calico_bpf_enabled: true
kube_proxy_remove: true
```

**NOTE:** there is known incompatibility in using the `kernel-kvm` kernel package on Ubuntu OSes because it is missing support for `CONFIG_NET_SCHED` which is a requirement for Calico eBPF support. When using Calico eBPF with Ubuntu ensure you run the `-generic` kernel.
Expand Down
10 changes: 0 additions & 10 deletions roles/kubernetes/preinstall/tasks/0020-verify-settings.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,16 +56,6 @@
- kube_network_plugin == 'calico'
- not ignore_assert_errors

- name: Stop if kube-proxy is enabled when using eBPF dataplane
assert:
that:
- kube_proxy_remove
msg: "kube-proxy needs to be disabled when using Calico with eBPF dataplane"
when:
- calico_bpf_enabled | default(false)
- kube_network_plugin == 'calico'
- not ignore_assert_errors

- name: Stop if unsupported version of Kubernetes
assert:
that: kube_version is version(kube_version_min_required, '>=')
Expand Down
2 changes: 2 additions & 0 deletions roles/kubespray-defaults/defaults/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ kubeadm_init_phases_skip: >-
{{ kubeadm_init_phases_skip_default }} + [ "addon/kube-proxy" ]
{%- elif kube_network_plugin == 'cilium' and (cilium_kube_proxy_replacement is defined and cilium_kube_proxy_replacement == 'strict') -%}
{{ kubeadm_init_phases_skip_default }} + [ "addon/kube-proxy" ]
{%- elif kube_network_plugin == 'calico' and (calico_bpf_enabled is defined and calico_bpf_enabled) -%}
{{ kubeadm_init_phases_skip_default }} + [ "addon/kube-proxy" ]
{%- elif kube_proxy_remove is defined and kube_proxy_remove -%}
{{ kubeadm_init_phases_skip_default }} + [ "addon/kube-proxy" ]
{%- else -%}
Expand Down
1 change: 0 additions & 1 deletion tests/files/packet_centos8-calico-ha-ebpf.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ kube_network_plugin: calico
deploy_netchecker: true

calico_bpf_enabled: true
kube_proxy_remove: true
loadbalancer_apiserver_localhost: true
use_localhost_as_kubeapi_loadbalancer: true

Expand Down

0 comments on commit f906163

Please sign in to comment.