Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cgroupsv2 where available (fedora) #8237

Merged
merged 3 commits into from
Dec 6, 2021
Merged

Use cgroupsv2 where available (fedora) #8237

merged 3 commits into from
Dec 6, 2021

Conversation

cristicalin
Copy link
Contributor

@cristicalin cristicalin commented Nov 27, 2021 •
edited by floryut
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:
Modern container managers support cgroupsv2 and we should not disable it anymore. We already have distributions with cgroupsv2 in CI (fedora), this change lets us confirm the support for them.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add support for cgroups v2 (no more reverting to cgroups v1 for Fedora)

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 27, 2021
@k8s-ci-robot k8s-ci-robot requested review from bozzo and EppO November 27, 2021 19:17
@champtar
Copy link
Contributor

We should also set kubelet_cgroup_driver to systemd as it's the recommended runc setting with cgroupv2
(and fix containerd config to use kubelet_cgroup_driver)

@cristicalin
Copy link
Contributor Author

We should also set kubelet_cgroup_driver to systemd as it's the recommended runc setting with cgroupv2 (and fix containerd config to use kubelet_cgroup_driver)

You mean like we did in https://github.com/kubernetes-sigs/kubespray/pull/8206/files ?

kubelet_cgroup_driver is detected automatically even for cgroupsv2, do you want to pin it in the CI file or you have something else in mind?

@champtar
Copy link
Contributor

All good then, I was grepping for systemdCgroup but didn't git pull for some time ...

@floryut
Copy link
Member

floryut commented Nov 30, 2021

Shouldn't this file be updated too for the same behavior ?

kubespray/roles/container-engine/cri-o/tasks/main.yaml

Line 38 in 0cdf75d

- name: disable unified_cgroup_hierarchy in Fedora 31+

@cristicalin
Copy link
Contributor Author

To be perfectly honest I only tested with containerd and have not looked into cri-o support for cgroups v2. We also do this for docker so we should probably extend the change to all 3.

/hold - while I do some experimentation

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 30, 2021
@cristicalin cristicalin changed the title Containerd: use cgroupsv2 where available (fedora) Use cgroupsv2 where available (fedora) Nov 30, 2021
@floryut
Copy link
Member

floryut commented Dec 1, 2021

@cristicalin You may rebase #8258 as soon as it's merged 👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2021
@cristicalin
Copy link
Contributor Author

This should be good to go after it passes CI.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2021
@oomichi
Copy link
Contributor

oomichi commented Dec 6, 2021

Thanks for doing this.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2021
@k8s-ci-robot k8s-ci-robot merged commit c98a078 into kubernetes-sigs:master Dec 6, 2021
nmasse-itix pushed a commit to nmasse-itix/kubespray that referenced this pull request Dec 8, 2021
@cristicalin @nmasse-itix
Use cgroupsv2 where available (fedora) (kubernetes-sigs#8237)
28a1e70 
* Containerd: use cgroupsv2 where available (fedora)

* Docker: use cgroupsv2 where available (fedora)

* cri-o: use cgroupsv2 where available (fedora)
@floryut floryut mentioned this pull request Dec 21, 2021
Closed
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
@cristicalin @sakuraiyuta
Use cgroupsv2 where available (fedora) (kubernetes-sigs#8237)
b11c551 
* Containerd: use cgroupsv2 where available (fedora)

* Docker: use cgroupsv2 where available (fedora)

* cri-o: use cgroupsv2 where available (fedora)
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 28, 2023
@cristicalin @LuckySB
Use cgroupsv2 where available (fedora) (kubernetes-sigs#8237)
a0ddff1 
* Containerd: use cgroupsv2 where available (fedora)

* Docker: use cgroupsv2 where available (fedora)

* cri-o: use cgroupsv2 where available (fedora)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@bozzo bozzo Awaiting requested review from bozzo

@EppO EppO Awaiting requested review from EppO

Assignees

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cristicalin @champtar @floryut @k8s-ci-robot @oomichi