Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cri-o default package to 1.22 #8258

Merged
merged 1 commit into from
Dec 2, 2021

Conversation

floryut
Copy link
Member

@floryut floryut commented Dec 1, 2021

What type of PR is this?
/kind feature

What this PR does / why we need it:
crio 1.22 is available for pretty much every OS, we kind of forgot to switch to it

Which issue(s) this PR fixes:
None

Special notes for your reviewer:
None

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 1, 2021
@floryut floryut marked this pull request as draft December 1, 2021 09:53
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 1, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 1, 2021
@floryut floryut force-pushed the crio_version branch 3 times, most recently from 9fbe13b to 72b7a8b Compare December 1, 2021 10:25
@floryut floryut marked this pull request as ready for review December 1, 2021 10:25
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 1, 2021
@cristicalin
Copy link
Contributor

cristicalin commented Dec 1, 2021

Molecule test still failing:

fatal: [fedora]: FAILED! => {"changed": false, "cmd": ["dnf", "-y", "module", "enable", "cri-o:1.22"], "delta": "0:00:01.592206", "end": "2021-12-01 13:25:26.501613", "msg": "non-zero return code", "rc": 1, "start": "2021-12-01 13:25:24.909407", "stderr": "Error: Problems in request:\nmissing groups or modules: cri-o:1.22", "stderr_lines": ["Error: Problems in request:", "missing groups or modules: cri-o:1.22"], "stdout": "Last metadata expiration check: 0:01:09 ago on Wed Dec  1 13:24:17 2021.", "stdout_lines": ["Last metadata expiration check: 0:01:09 ago on Wed Dec  1 13:24:17 2021."]}

Maybe the molecule test should be updated with fedora 35 image? Is the cri-o 1.22 available just on 35?

@cristicalin
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2021
@k8s-ci-robot k8s-ci-robot merged commit b38382a into kubernetes-sigs:master Dec 2, 2021
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants