-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'avoid-buggy-ips' support of MetalLB #9166
Add 'avoid-buggy-ips' support of MetalLB #9166
Conversation
Hi @kerryeon. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @kerryeon, please rebase this PR on current master branch to include the CI fix in #9175 |
a0df7be
to
88182be
Compare
Sure, I rebased it to the latest commit. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
/ok-to-test
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kerryeon, oomichi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* upstream/master: (832 commits) add pre-commit hook to facilitate local testing (kubernetes-sigs#9158) cri-dockerd: add restart of docker.service (kubernetes-sigs#9205) do not run etcd role in scale.yml playbook when etcd installed by kubeadm (kubernetes-sigs#9210) optimize the format of evictionHard in kubelet-config.yaml template (kubernetes-sigs#9204) Update vars.md (kubernetes-sigs#9172) fix one bug in docs/nodes (kubernetes-sigs#9203) Fix containerd (<1.7) configuration for insecure registries (kubernetes-sigs#9207) 🌱 Enable cri-dockerd service (kubernetes-sigs#9201) Update vsphere-csi.md (kubernetes-sigs#9170) 9035: Make Cilium rolling-restart delay/timeout configurable (kubernetes-sigs#9176) [kubernetes] Add hashes for 1.24.4, 1.22.13, 1.23.10 and make v1.24.4 default (kubernetes-sigs#9191) Add 'avoid-buggy-ips' support of MetalLB (kubernetes-sigs#9166) Add the option to enable default Pod Security Configuration (kubernetes-sigs#9017) Add 'flush ip6tables' task in reset role (kubernetes-sigs#9168) add list nodes rules to cilium-operator clusterrole (kubernetes-sigs#9178) docs(kube-vip): fix broken links (kubernetes-sigs#9165) Disable DNSStubListener for Flatcar Linux (kubernetes-sigs#9160) Subnet setup order fix & Number of master nodes syntax fix (kubernetes-sigs#9159) Fix CSI drivers issues on Azure (kubernetes-sigs#9153) [calico] calico rr supports multiple groups (kubernetes-sigs#9134) ...
What type of PR is this?
/kind feature
What this PR does / why we need it:
avoid-buggy-ips
is a kind of feature of MetalLB, and it has a function to prevent load-balancing of IPs that are practically unavailable such as:192.168.0.0
,192.168.0.255
in 192.168.0.0/24This feature is disabled in MetalLB by default, but there is no manual in Kubespray.
So when I try to use MetalLB with CIDR IP subnets, these useless IPs are necessarily assigned.
Therefore, I thought that this function should be controllable in Kubespray as well, and I implemented it as follows:
metallb_avoid_buggy_ips
for default IP address poolavoid_buggy_ips
for additional IP address pools defined inmetallb_additional_address_pools
Examples
Separately, I added this to the
docs/metallb.md
documentation as examples to indicate that it can be used.Which issue(s) this PR fixes:
Fixes #4158 (MetalLB configuration via Inventory)
Special notes for your reviewer:
Does this PR introduce a user-facing change?: