Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'avoid-buggy-ips' support of MetalLB #9166

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

HoKim98
Copy link
Contributor

@HoKim98 HoKim98 commented Aug 11, 2022

What type of PR is this?
/kind feature

What this PR does / why we need it:

avoid-buggy-ips is a kind of feature of MetalLB, and it has a function to prevent load-balancing of IPs that are practically unavailable such as:

  • 192.168.0.0, 192.168.0.255 in 192.168.0.0/24

This feature is disabled in MetalLB by default, but there is no manual in Kubespray.
So when I try to use MetalLB with CIDR IP subnets, these useless IPs are necessarily assigned.

Therefore, I thought that this function should be controllable in Kubespray as well, and I implemented it as follows:

  • metallb_avoid_buggy_ips for default IP address pool
  • avoid_buggy_ips for additional IP address pools defined in metallb_additional_address_pools

Examples

metallb_enabled: true
metallb_ip_range:
  - 10.5.0.0/16
metallb_avoid_buggy_ips: true  # new feature
metallb_additional_address_pools:
  kube_service_pool_1:
    ip_range:
      - 10.6.0.0/16
    protocol: "bgp"
    auto_assign: false
    avoid_buggy_ips: true  # new feature
  kube_service_pool_2:
    ip_range:
      - 10.10.0.0/16
    protocol: "bgp"
    auto_assign: false
    avoid_buggy_ips: true  # new feature

Separately, I added this to the docs/metallb.md documentation as examples to indicate that it can be used.

Which issue(s) this PR fixes:

Fixes #4158 (MetalLB configuration via Inventory)

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Added 'avoid-buggy-ips' support of MetalLB (`metallb_avoid_buggy_ips` for default IP address pool and `avoid_buggy_ips` for additional IP address pools defined in `metallb_additional_address_pools`) (⚠️/!\ ADD NOTE : As the newly added feature uses the default value of MetalLB as same, there is no side effect for users who do not change it's value)

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 11, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @kerryeon. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 11, 2022
@yankay
Copy link
Member

yankay commented Aug 12, 2022

89822D38AB234E4A2EC1836C3E79B89E

@cristicalin
Copy link
Contributor

Hi @kerryeon, please rebase this PR on current master branch to include the CI fix in #9175

@HoKim98 HoKim98 force-pushed the metallb-config-add branch from a0df7be to 88182be Compare August 18, 2022 01:39
@HoKim98
Copy link
Contributor Author

HoKim98 commented Aug 18, 2022

Sure, I rebased it to the latest commit.

@yankay
Copy link
Member

yankay commented Aug 19, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2022
Copy link
Contributor

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

/ok-to-test
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 19, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kerryeon, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2022
@k8s-ci-robot k8s-ci-robot merged commit e318908 into kubernetes-sigs:master Aug 19, 2022
TinLe added a commit to TinLe/kubespray that referenced this pull request Aug 27, 2022
* upstream/master: (832 commits)
  add pre-commit hook to facilitate local testing (kubernetes-sigs#9158)
  cri-dockerd: add restart of docker.service (kubernetes-sigs#9205)
  do not run etcd role in scale.yml playbook when etcd installed by kubeadm (kubernetes-sigs#9210)
  optimize the format of evictionHard in kubelet-config.yaml template (kubernetes-sigs#9204)
  Update vars.md (kubernetes-sigs#9172)
  fix one bug in docs/nodes (kubernetes-sigs#9203)
  Fix containerd (<1.7) configuration for insecure registries (kubernetes-sigs#9207)
  🌱 Enable cri-dockerd service (kubernetes-sigs#9201)
  Update vsphere-csi.md (kubernetes-sigs#9170)
  9035: Make Cilium rolling-restart delay/timeout configurable (kubernetes-sigs#9176)
  [kubernetes] Add hashes for 1.24.4, 1.22.13, 1.23.10 and make v1.24.4 default (kubernetes-sigs#9191)
  Add 'avoid-buggy-ips' support of MetalLB (kubernetes-sigs#9166)
  Add the option to enable default Pod Security Configuration (kubernetes-sigs#9017)
  Add 'flush ip6tables' task in reset role (kubernetes-sigs#9168)
  add list nodes rules to cilium-operator clusterrole (kubernetes-sigs#9178)
  docs(kube-vip): fix broken links (kubernetes-sigs#9165)
  Disable DNSStubListener for Flatcar Linux (kubernetes-sigs#9160)
  Subnet setup order fix & Number of master nodes syntax fix (kubernetes-sigs#9159)
  Fix CSI drivers issues on Azure (kubernetes-sigs#9153)
  [calico] calico rr supports multiple groups (kubernetes-sigs#9134)
  ...
@HoKim98 HoKim98 deleted the metallb-config-add branch September 1, 2022 05:03
@floryut floryut mentioned this pull request Sep 19, 2022
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jul 2, 2023
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MetalLB configuration via Inventory
5 participants