Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typos fixed in vsphere-csi.md #9170

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Typos fixed in vsphere-csi.md #9170

merged 1 commit into from
Aug 22, 2022

Conversation

bishal7679
Copy link
Member

What type of PR is this?
/kind documentation

What this PR does / why we need it:

Typos registrat fixed now by this PR

Which issue(s) this PR fixes:

Fixes #9169

  typos `registrat` updated to `registrar`

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 12, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 12, 2022
@bishal7679
Copy link
Member Author

/assign @LuckySB

__
sema-logo  Summary: 🛠️ This code needs a fix

@yankay
Copy link
Member

yankay commented Aug 13, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2022
@cristicalin
Copy link
Contributor

Hi @bishal7679 please rebase this PR on current master branch to include the fix in #9175

@bishal7679
Copy link
Member Author

Hi @bishal7679 please rebase this PR on current master branch to include the fix in #9175

In which branch I have to rebase my local branch??

@cristicalin
Copy link
Contributor

@bishal7679 you nee to rebase on current master branch, the fix is already merged. this guide might help

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 20, 2022
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 20, 2022
@cristicalin
Copy link
Contributor

Thanks @bishal7679 !

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2022
floryut
floryut approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
@bishal7679 Thank you

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bishal7679, cristicalin, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cristicalin,floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@floryut floryut added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 22, 2022
@k8s-ci-robot k8s-ci-robot merged commit fddff78 into kubernetes-sigs:master Aug 22, 2022
TinLe added a commit to TinLe/kubespray that referenced this pull request Aug 27, 2022
@TinLe
Merge remote-tracking branch 'upstream/master'
3fa0d59 
* upstream/master: (832 commits)
  add pre-commit hook to facilitate local testing (kubernetes-sigs#9158)
  cri-dockerd: add restart of docker.service (kubernetes-sigs#9205)
  do not run etcd role in scale.yml playbook when etcd installed by kubeadm (kubernetes-sigs#9210)
  optimize the format of evictionHard in kubelet-config.yaml template (kubernetes-sigs#9204)
  Update vars.md (kubernetes-sigs#9172)
  fix one bug in docs/nodes (kubernetes-sigs#9203)
  Fix containerd (<1.7) configuration for insecure registries (kubernetes-sigs#9207)
  🌱 Enable cri-dockerd service (kubernetes-sigs#9201)
  Update vsphere-csi.md (kubernetes-sigs#9170)
  9035: Make Cilium rolling-restart delay/timeout configurable (kubernetes-sigs#9176)
  [kubernetes] Add hashes for 1.24.4, 1.22.13, 1.23.10 and make v1.24.4 default (kubernetes-sigs#9191)
  Add 'avoid-buggy-ips' support of MetalLB (kubernetes-sigs#9166)
  Add the option to enable default Pod Security Configuration (kubernetes-sigs#9017)
  Add 'flush ip6tables' task in reset role (kubernetes-sigs#9168)
  add list nodes rules to cilium-operator clusterrole (kubernetes-sigs#9178)
  docs(kube-vip): fix broken links (kubernetes-sigs#9165)
  Disable DNSStubListener for Flatcar Linux (kubernetes-sigs#9160)
  Subnet setup order fix & Number of master nodes syntax fix (kubernetes-sigs#9159)
  Fix CSI drivers issues on Azure (kubernetes-sigs#9153)
  [calico] calico rr supports multiple groups (kubernetes-sigs#9134)
  ...
alegrey91 pushed a commit to alegrey91/kubespray that referenced this pull request Aug 29, 2022
@bishal7679 @alegrey91
Update vsphere-csi.md (kubernetes-sigs#9170)
1a32c40
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
@bishal7679 @nolimitkun
Update vsphere-csi.md (kubernetes-sigs#9170)
4562e12
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jul 7, 2023
@bishal7679 @LuckySB
Update vsphere-csi.md (kubernetes-sigs#9170)
c352e37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@cristicalin cristicalin Awaiting requested review from cristicalin

@liupeng0518 liupeng0518 Awaiting requested review from liupeng0518

Assignees

@yankay yankay

@LuckySB LuckySB

@floryut floryut

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typos in kubespray/docs/vsphere-csi.md
6 participants
@bishal7679 @yankay @cristicalin @k8s-ci-robot @floryut @LuckySB