Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A mechanism to list the Workloads that are admitted and not finished #1776

Closed
2 of 3 tasks
alculquicondor opened this issue Feb 27, 2024 · 21 comments
Closed
2 of 3 tasks
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@alculquicondor
Copy link
Contributor

What would you like to be added:

Some way of querying the list of Workloads that are still "running", that is, they are admitted and don't have a Finished condition. Querying by ClusterQueue would be ideal too.

Some options (not necessarily exclusive to each other):

  • The kueue CLI
  • A visibility endpoint.
  • Is there a way to do this just with a kubectl jsonpath?

Why is this needed:

For basic diagnostics of the state of the cluster.

Completion requirements:

This enhancement requires the following artifacts:

  • Design doc
  • API change?
  • Docs update

The artifacts should be linked in subsequent comments.

@alculquicondor alculquicondor added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 27, 2024
@tenzen-y
Copy link
Member

Do you expect that we extend the on-demand visibility server or save information on any CustomResource like ClusterQueue?

@alculquicondor
Copy link
Contributor Author

I don't think we should save it. This is more for on-demand queries.

@tenzen-y
Copy link
Member

I don't think we should save it. This is more for on-demand queries.

It makes sense.

@astefanutti
Copy link
Member

Tangentially, do you think adding a running_worloads metric could be useful too?

@tenzen-y
Copy link
Member

Tangentially, do you think adding a running_worloads metric could be useful too?

Does it mean Prometheus metric?

@astefanutti
Copy link
Member

Tangentially, do you think adding a running_worloads metric could be useful too?

Does it mean Prometheus metric?

Yes, a Prometheus metric, that would complement the existing pending_workloads metric.

@alculquicondor
Copy link
Contributor Author

we already have it

AdmittedActiveWorkloads = prometheus.NewGaugeVec(
prometheus.GaugeOpts{
Subsystem: constants.KueueName,
Name: "admitted_active_workloads",
Help: "The number of admitted Workloads that are active (unsuspended and not finished), per 'cluster_queue'",
}, []string{"cluster_queue"},
)

@astefanutti
Copy link
Member

we already have it

AdmittedActiveWorkloads = prometheus.NewGaugeVec(
prometheus.GaugeOpts{
Subsystem: constants.KueueName,
Name: "admitted_active_workloads",
Help: "The number of admitted Workloads that are active (unsuspended and not finished), per 'cluster_queue'",
}, []string{"cluster_queue"},
)

Ah right, this is the one, thanks!

@alculquicondor
Copy link
Contributor Author

alculquicondor commented Feb 28, 2024

Would you like to propose something for this area? Maybe along the lines of a new visibility endpoint?

@astefanutti
Copy link
Member

Yes. Do you want it to be initially proposed as a KEP?

@alculquicondor
Copy link
Contributor Author

Given that it's an API change, a KEP would be good.

@tenzen-y
Copy link
Member

Feel free to assign yourself with /assign.
Since you joined this org, the command should work well :)

@KunWuLuan
Copy link
Contributor

If no one working for this, I can help.

@astefanutti
Copy link
Member

@KunWuLuan I haven't got the chance to work on it. Feel free to assign it to you.

@KunWuLuan
Copy link
Contributor

Do we still need the new endpoints if we already have the KueueCtl?

@alculquicondor
Copy link
Contributor Author

Maybe less so? One slight advantage would be to filter on the server side.

But maybe it would add unnecessary load to the kueue binary?

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 4, 2024
@tenzen-y
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 14, 2024
@alculquicondor
Copy link
Contributor Author

This is supported using kueuectl https://kueue.sigs.k8s.io/docs/reference/kubectl-kueue/commands/kueuectl_list/kueuectl_list_workload/

Should we close this?

@tenzen-y
Copy link
Member

This is supported using kueuectl https://kueue.sigs.k8s.io/docs/reference/kubectl-kueue/commands/kueuectl_list/kueuectl_list_workload/

Should we close this?

Oh, you're right. Let me close this.
/close

@k8s-ci-robot
Copy link
Contributor

@tenzen-y: Closing this issue.

In response to this:

This is supported using kueuectl https://kueue.sigs.k8s.io/docs/reference/kubectl-kueue/commands/kueuectl_list/kueuectl_list_workload/

Should we close this?

Oh, you're right. Let me close this.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants