-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP 2076: Kueuectl #2093
KEP 2076: Kueuectl #2093
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
* LocalQueue | ||
* ClusterQueue | ||
* Status | ||
* Position in Queue (if Pending) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will depend on #1776
cc @KunWuLuan
I think the administrative use case is good, but it seems much smaller than what I hoped for with respect to this tool - a way to manage and understand the running workloads (the user case, for which I think there are many more than administrators). Looking forward (hoping) to see the latter. |
-—only-pending | ||
—-only-admitted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of --condition=Pending|Admitted
, could we provide a field selector for more flexibility?
keps/2076-kueuectl/README.md
Outdated
We want to create a command line tool for Kueue that allows to: | ||
|
||
* list Kueue's objects with easy to use Kueue-specific filtering, | ||
* create Local and ClusterQueues without touching yamls, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to help generate yamls?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, with --dry-run you will get just the yaml.
Co-authored-by: Aldo Culquicondor <1299064+alculquicondor@users.noreply.github.com> Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Leaving LGTM to @tenzen-y
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, mwielgus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise lgtm
# The most recent milestone for which work toward delivery of this KEP has been | ||
# done. This can be the current (upcoming) milestone, if it is being actively | ||
# worked on. | ||
latest-milestone: "v0.8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
latest-milestone: "v0.8" | |
latest-milestone: "v0.7" |
@mwielgus Isn't this target v0.7? Because we already implemented the part of the command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although we will likely not finish a meaningful amount of commands. Not sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If your team doesn't have enough time to implement commands, I'm ok with postponing it to v0.8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
alpha: "v0.8" | ||
beta: "v0.9" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alpha: "v0.8" | |
beta: "v0.9" | |
alpha: "v0.7" | |
beta: "v0.8" |
LGTM label has been added. Git tree hash: 237c9c3803630c6ce3f7c045619e3bcc1cbdc86c
|
What type of PR is this?
/kind feature
What this PR does / why we need it:
Introduces command line tool for Kueue management and API listing.
Which issue(s) this PR fixes:
Fixes #2076
Special notes for your reviewer:
Does this PR introduce a user-facing change?