Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP 2076: Kueuectl #2093

Merged
merged 3 commits into from
May 1, 2024
Merged

Conversation

mwielgus
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Introduces command line tool for Kueue management and API listing.

Which issue(s) this PR fixes:

Fixes #2076

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. labels Apr 29, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 29, 2024
Copy link

netlify bot commented Apr 29, 2024

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 8b34b12
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/663280f6beddcc00088ddbf1

@alculquicondor
Copy link
Contributor

cc @tenzen-y @vsoch

keps/2076-kueuectl/README.md Outdated Show resolved Hide resolved
keps/2076-kueuectl/README.md Outdated Show resolved Hide resolved
keps/2076-kueuectl/README.md Outdated Show resolved Hide resolved
keps/2076-kueuectl/README.md Outdated Show resolved Hide resolved
keps/2076-kueuectl/README.md Outdated Show resolved Hide resolved
keps/2076-kueuectl/README.md Outdated Show resolved Hide resolved
* LocalQueue
* ClusterQueue
* Status
* Position in Queue (if Pending)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will depend on #1776

cc @KunWuLuan

keps/2076-kueuectl/README.md Outdated Show resolved Hide resolved
keps/2076-kueuectl/README.md Outdated Show resolved Hide resolved
keps/2076-kueuectl/README.md Outdated Show resolved Hide resolved
@vsoch
Copy link
Contributor

vsoch commented Apr 29, 2024

I think the administrative use case is good, but it seems much smaller than what I hoped for with respect to this tool - a way to manage and understand the running workloads (the user case, for which I think there are many more than administrators). Looking forward (hoping) to see the latter.

keps/2076-kueuectl/README.md Outdated Show resolved Hide resolved
keps/2076-kueuectl/README.md Outdated Show resolved Hide resolved
keps/2076-kueuectl/README.md Outdated Show resolved Hide resolved
keps/2076-kueuectl/README.md Outdated Show resolved Hide resolved
keps/2076-kueuectl/README.md Show resolved Hide resolved
keps/2076-kueuectl/README.md Show resolved Hide resolved
keps/2076-kueuectl/README.md Show resolved Hide resolved
Comment on lines +210 to +211
-—only-pending
—-only-admitted
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of --condition=Pending|Admitted, could we provide a field selector for more flexibility?

keps/2076-kueuectl/README.md Show resolved Hide resolved
We want to create a command line tool for Kueue that allows to:

* list Kueue's objects with easy to use Kueue-specific filtering,
* create Local and ClusterQueues without touching yamls,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to help generate yamls?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, with --dry-run you will get just the yaml.

Co-authored-by: Aldo Culquicondor <1299064+alculquicondor@users.noreply.github.com>
Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Leaving LGTM to @tenzen-y

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 1, 2024
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise lgtm

# The most recent milestone for which work toward delivery of this KEP has been
# done. This can be the current (upcoming) milestone, if it is being actively
# worked on.
latest-milestone: "v0.8"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
latest-milestone: "v0.8"
latest-milestone: "v0.7"

@mwielgus Isn't this target v0.7? Because we already implemented the part of the command.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although we will likely not finish a meaningful amount of commands. Not sure.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If your team doesn't have enough time to implement commands, I'm ok with postponing it to v0.8.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Comment on lines +24 to +25
alpha: "v0.8"
beta: "v0.9"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
alpha: "v0.8"
beta: "v0.9"
alpha: "v0.7"
beta: "v0.8"

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 1, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 237c9c3803630c6ce3f7c045619e3bcc1cbdc86c

@k8s-ci-robot k8s-ci-robot merged commit 43e5eb8 into kubernetes-sigs:main May 1, 2024
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.7 milestone May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command line tool for clusterqueue/localqueue/workload listing and management
7 participants