-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multikueue initial implementation #1313
Conversation
Skipping CI for Draft Pull Request. |
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
/test all |
/test pull-kueue-test-e2e-main-1-25 |
/test pull-kueue-test-e2e-main-1-28 |
This will be very helpful for manual and automated testing, thanks! |
/test pull-kueue-test-e2e-main-1-28 |
/test all |
Sure, however ,for the time being I propose to keep it as draft until we have a real job for it to do. |
/test all |
/test all |
/test all |
/test all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, some nits, remaining ask about the rootContext, and make sure we have the follow ups listed
I still have two comments pending: I consider them non-blocking, because Still, feel free to address these nice-to-haves, I will renew LGTM. /lgtm In case @tenzen-y has some other questions |
LGTM label has been added. Git tree hash: 9ef999d8d174f897d1e313a9260b021352821577
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall lgtm
}, | ||
}, | ||
}, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@trasc Where is its case? I could not find it.
|
||
type remoteController struct { | ||
localClient client.Client | ||
watchCtx context.Context |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@trasc What is a real object
? Does this mean that after we graduate MultiKueueConfig to beta?
|
||
func (a *wlReconciler) Reconcile(ctx context.Context, req reconcile.Request) (reconcile.Result, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, even if we add markers here, manifests aren't updated.
However, we have been adding markers to all reconcilers so that we can clarify which permissions the reconciler must have.
So, I still think that having kubebuilder markers would be better. Or we should add markers to the batchJobAdapter
instead of here.
g.Expect(managerCluster.client.Get(managerCluster.ctx, acKey, &updatetedAc)).To(gomega.Succeed()) | ||
cond := apimeta.FindStatusCondition(updatetedAc.Status.Conditions, kueue.AdmissionCheckActive) | ||
g.Expect(cond).NotTo(gomega.BeNil()) | ||
g.Expect(cond.Status).To(gomega.Equal(metav1.ConditionTrue), "Reason: %s, Message: %q", cond.Reason, cond.Status) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice error message.
Still |
LGTM label has been added. Git tree hash: 89a095055d41d19e6daa7200ba7b79d5391eb5a1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@trasc Thank you!
/lgtm
/approve
/hold cancel
}, | ||
}, | ||
}, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, that's right. Thanks.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, tenzen-y, trasc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/release-note-edit
|
/kind feature |
/kind api-change |
/release-note-edit
|
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add the basic functionality of MultiKueue.
Which issue(s) this PR fixes:
Relates to #693
Special notes for your reviewer:
Noteble differences vs KEP:
They can be in follow-ups.
Other follow-up points:
We need to be sure that the local job controller is not starting the execution once the job is unsuspended.
Currently the workload is skipped.
Does this PR introduce a user-facing change?