Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MultiKueue support for JobSet #1606

Merged
merged 8 commits into from
Jan 23, 2024
Merged

Add MultiKueue support for JobSet #1606

merged 8 commits into from
Jan 23, 2024

Conversation

trasc
Copy link
Contributor

@trasc trasc commented Jan 17, 2024 •
edited by k8s-ci-robot

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds MultiKueue support for JobSet.

Which issue(s) this PR fixes:

Relates to #693

Special notes for your reviewer:

Does this PR introduce a user-facing change?

MultiKueue: Support for JobSets.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 17, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 17, 2024 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 5aa8bba
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/65af6524e4a18a0008149932

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 17, 2024
@trasc trasc force-pushed the multikueue-jobset branch 6 times, most recently from 0e9f94b to 96189ed Compare January 18, 2024 08:08
@trasc
Copy link
Contributor Author

trasc commented Jan 18, 2024

/test all

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 18, 2024
@trasc trasc changed the title [WIP] Multikueue jobset Add MultiKueue support for JobSet Jan 18, 2024
@trasc
Copy link
Contributor Author

trasc commented Jan 18, 2024

/hold

for rebase after #1313 is merged

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2024
@trasc trasc marked this pull request as ready for review January 18, 2024 09:18
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 18, 2024
mimowo
mimowo reviewed Jan 18, 2024
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very initial pass, will continue once aligned with base PR

hack/multikueue-e2e-test.sh Outdated Show resolved Hide resolved
hack/multikueue-e2e-test.sh Show resolved Hide resolved
hack/multikueue-e2e-test.sh Outdated Show resolved Hide resolved
hack/multikueue-e2e-test.sh Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 18, 2024
@trasc
Copy link
Contributor Author

trasc commented Jan 18, 2024

/unhold
/cc @alculquicondor

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 602d5d6b2a0e338bc6ef69f5054aa8476c08eeb8

alculquicondor
alculquicondor reviewed Jan 22, 2024
View reviewed changes
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just minor things

/approve

hack/multikueue-e2e-test.sh Show resolved Hide resolved
hack/multikueue-e2e-test.sh Outdated Show resolved Hide resolved
pkg/controller/admissionchecks/multikueue/jobset_adapter.go
return localClient.Status().Update(ctx, &localJob)
}

func (b *jobsetAdapter) DeleteRemoteObject(ctx context.Context, remoteClient client.Client, key types.NamespacedName) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function doesn't seem to need any adaptation.
Can you explain why you need to "Get" the objects, instead of calling Delete directly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function doesn't seem to need any adaptation.

The adaption is needed due to the different job type.
Some alternative could be :

  1. keep the method and create a generic helper (but the helper will not do very much)
  2. do the deletion via unstructured (but it's harder to follow in my opinion)

Can you explain why you need to "Get" the objects, instead of calling Delete directly?

The caller only has the key of the job not the job object.

test/integration/multikueue/multikueue_test.go Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, trasc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2024
@alculquicondor
Copy link
Contributor

/hold for nits

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2024
@trasc
Copy link
Contributor Author

trasc commented Jan 23, 2024

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2024
@mimowo
Copy link
Contributor

mimowo commented Jan 23, 2024

/lgtm
I believe the nits are applied, the remaining question is answered #1606 (comment). In case something can be improved we can do in a follow-up.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d53ca3af7d0119a0dd7a8cfa1dd62c42be1ef55f

@k8s-ci-robot k8s-ci-robot merged commit d28166b into kubernetes-sigs:main Jan 23, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.6 milestone Jan 23, 2024
@trasc trasc deleted the multikueue-jobset branch January 23, 2024 09:15
@alculquicondor
Copy link
Contributor

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 23, 2024
@alculquicondor
Copy link
Contributor

/release-note-edit

MultiKueue: Support for JobSets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denkensk denkensk Awaiting requested review from denkensk

@kerthcet kerthcet Awaiting requested review from kerthcet

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@mimowo mimowo Awaiting requested review from mimowo

@tenzen-y tenzen-y Awaiting requested review from tenzen-y

Assignees

@alculquicondor alculquicondor

@mimowo mimowo

@tenzen-y tenzen-y

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v0.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@trasc @k8s-ci-robot @alculquicondor @mimowo @tenzen-y