-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pods] Finalize the replaced pods #1766
[pods] Finalize the replaced pods #1766
Conversation
Skipping CI for Draft Pull Request. |
/test all |
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
cbba6d6
to
cb43501
Compare
/test all |
cb43501
to
0ec3433
Compare
/cc @alculquicondor |
cc12842
to
aea8fe2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits just for future reference.
/lgtm
/approve
/cherry-pick release-0.6
LGTM label has been added. Git tree hash: 6a6c6ac0a8df89aad7977fdcf5ea5a1d9557fe1e
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, trasc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
LGTM label has been added. Git tree hash: d590e2f299bc666aef97cfee1f971269acecc338
|
/cherry-pick release-0.6 |
@alculquicondor: once the present PR merges, I will cherry-pick it on top of release-0.6 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Maybe the last attempt didn't catch the recently merged fix /retest |
@alculquicondor: #1766 failed to apply on top of branch "release-0.6":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@trasc please create a cherry-pick and highlight in the description any significant changes compared to this PR. |
* [slices] Add Pick * [pods] Delete the replaced pods * KEP Update * Review Remarks * Refactor cleanupExcessPods * [jobframework] Drop EnsureWorkloadOwnedByAllMembers from the ComposableJob interface. * Review Remarks * Review Remarks * nits * Review Remarks
/kind bug |
/release-note-edit
|
What type of PR is this?
/kind feature
What this PR does / why we need it:
Finalize the Failed pods in a pod-group once a replacement pods are created.
Which issue(s) this PR fixes:
Fixes #1762
Special notes for your reviewer:
Does this PR introduce a user-facing change?