Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pods] Finalize the replaced pods #1766

Merged

Conversation

trasc
Copy link
Contributor

@trasc trasc commented Feb 23, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Finalize the Failed pods in a pod-group once a replacement pods are created.

Which issue(s) this PR fixes:

Fixes #1762

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Pod Integration: Finalize failed pods in a pod-group when replacement pods are created

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 23, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 23, 2024
@trasc
Copy link
Contributor Author

trasc commented Feb 23, 2024

/test all

Copy link

netlify bot commented Feb 23, 2024

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit e34470c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/65e620d525aba300085720b9

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 23, 2024
@trasc trasc force-pushed the pods-delete-failed-on-replacement branch from cbba6d6 to cb43501 Compare February 23, 2024 15:21
@trasc
Copy link
Contributor Author

trasc commented Feb 23, 2024

/test all

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 23, 2024
@trasc trasc marked this pull request as ready for review February 23, 2024 15:26
@trasc trasc changed the title WIP[pods] Delete the replaced pods [pods] Delete the replaced pods Feb 23, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 23, 2024
@trasc trasc force-pushed the pods-delete-failed-on-replacement branch from cb43501 to 0ec3433 Compare February 23, 2024 19:00
@trasc
Copy link
Contributor Author

trasc commented Feb 23, 2024

/cc @alculquicondor

pkg/util/slices/slices.go Outdated Show resolved Hide resolved
pkg/util/slices/slices_test.go Outdated Show resolved Hide resolved
pkg/controller/jobs/pod/pod_controller.go Outdated Show resolved Hide resolved
pkg/controller/jobs/pod/pod_controller.go Outdated Show resolved Hide resolved
keps/976-plain-pods/README.md Outdated Show resolved Hide resolved
keps/976-plain-pods/README.md Outdated Show resolved Hide resolved
pkg/controller/jobs/pod/pod_controller.go Outdated Show resolved Hide resolved
@trasc trasc force-pushed the pods-delete-failed-on-replacement branch 2 times, most recently from cc12842 to aea8fe2 Compare February 26, 2024 10:15
keps/976-plain-pods/README.md Outdated Show resolved Hide resolved
keps/976-plain-pods/README.md Outdated Show resolved Hide resolved
pkg/controller/jobs/pod/pod_controller.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 28, 2024
pkg/controller/jobs/pod/pod_controller.go Outdated Show resolved Hide resolved
pkg/controller/jobs/pod/pod_controller.go Show resolved Hide resolved
pkg/util/slices/slices.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 28, 2024
pkg/controller/jobs/pod/pod_controller.go Outdated Show resolved Hide resolved
pkg/controller/jobs/pod/pod_controller.go Outdated Show resolved Hide resolved
pkg/controller/jobs/pod/pod_controller.go Show resolved Hide resolved
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits just for future reference.

/lgtm
/approve
/cherry-pick release-0.6

pkg/controller/jobs/pod/pod_controller.go Outdated Show resolved Hide resolved
pkg/controller/jobs/pod/pod_controller.go Outdated Show resolved Hide resolved
pkg/controller/jobs/pod/pod_controller.go Outdated Show resolved Hide resolved
pkg/controller/jobs/pod/pod_controller.go Show resolved Hide resolved
pkg/controller/jobs/pod/pod_controller.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6a6c6ac0a8df89aad7977fdcf5ea5a1d9557fe1e

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, trasc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2024
@alculquicondor
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d590e2f299bc666aef97cfee1f971269acecc338

@alculquicondor
Copy link
Contributor

/cherry-pick release-0.6

@k8s-infra-cherrypick-robot

@alculquicondor: once the present PR merges, I will cherry-pick it on top of release-0.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alculquicondor
Copy link
Contributor

Maybe the last attempt didn't catch the recently merged fix

/retest

@k8s-ci-robot k8s-ci-robot merged commit 7e778f5 into kubernetes-sigs:main Mar 4, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.7 milestone Mar 4, 2024
@k8s-infra-cherrypick-robot

@alculquicondor: #1766 failed to apply on top of branch "release-0.6":

Applying: Add Pick
Applying: Delete the replaced pods
Applying: KEP Update
Applying: Review Remarks
Using index info to reconstruct a base tree...
M	keps/976-plain-pods/README.md
M	pkg/controller/jobs/pod/pod_controller.go
M	test/e2e/singlecluster/pod_test.go
M	test/integration/controller/jobs/pod/pod_controller_test.go
Falling back to patching base and 3-way merge...
Auto-merging test/integration/controller/jobs/pod/pod_controller_test.go
Auto-merging test/e2e/singlecluster/pod_test.go
CONFLICT (content): Merge conflict in test/e2e/singlecluster/pod_test.go
Auto-merging pkg/controller/jobs/pod/pod_controller.go
Auto-merging keps/976-plain-pods/README.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0004 Review Remarks
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-0.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alculquicondor
Copy link
Contributor

@trasc please create a cherry-pick and highlight in the description any significant changes compared to this PR.

@trasc trasc deleted the pods-delete-failed-on-replacement branch March 5, 2024 06:56
vsoch pushed a commit to researchapps/kueue that referenced this pull request Apr 18, 2024
* [slices] Add Pick

* [pods] Delete the replaced pods

* KEP Update

* Review Remarks

* Refactor cleanupExcessPods

* [jobframework] Drop EnsureWorkloadOwnedByAllMembers from the ComposableJob interface.

* Review Remarks

* Review Remarks

* nits

* Review Remarks
@alculquicondor
Copy link
Contributor

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label May 8, 2024
@alculquicondor
Copy link
Contributor

/release-note-edit

Pod Integration: Finalize failed pods in a pod-group when replacement pods are created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup Failed pods once replacement Pods are present
5 participants