-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-0.6][pods] Finalize the replaced pods #1801
[release-0.6][pods] Finalize the replaced pods #1801
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
/retest |
37bf10f
to
c850961
Compare
@trasc I guess that you need to sign commit with |
Signed-off-by: Traian Schiau <traian_schiau@epam.com>
c850961
to
6f26bf8
Compare
Alright, CLA has been passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
@trasc: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/approve cancel It seems that CONFLICTS still occur. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: d1e1dc8cab88dae91c095112b09ce9a3b3722bae
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y, trasc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Manual cherry-pick of #1766
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
The automatic cherry-pick was blocked by a conflict on deduplication of
corev1
import in e2e tests. Solved, no impact on the main logic.Does this PR introduce a user-facing change?