-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dereference StopPolicy before equality check #1897
Conversation
Hi @gabesaba. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch!
Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM label has been added. Git tree hash: 4c0c2e50539778cdef176c49209910a383ada99e
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gabesaba, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
I meant to say |
/cherry-pick release-0.6 |
@alculquicondor: new pull request created: #1917 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@alculquicondor: new pull request could not be created: failed to create pull request against kubernetes-sigs/kueue#release-0.6 from head k8s-infra-cherrypick-robot:cherry-pick-1897-to-release-0.6: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for k8s-infra-cherrypick-robot:cherry-pick-1897-to-release-0.6."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/release-note-edit
|
/kind bug |
* Dereference StopPolicy before equality check * Update pkg/controller/core/workload_controller.go Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com> * Update pkg/controller/core/workload_controller.go Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com> --------- Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
What type of PR is this?
What this PR does / why we need it:
I was investigating why we were doing a large amount of workload reconciles, and found that this equality check wasn't working as intended.
Compare workload reconciles before/after (1k jobs, 10k pods)
Does this PR introduce a user-facing change?