Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.6] Dereference StopPolicy before equality check #1917

Merged
merged 3 commits into from
Mar 26, 2024
Merged

[release-0.6] Dereference StopPolicy before equality check #1917

merged 3 commits into from
Mar 26, 2024

Conversation

k8s-infra-cherrypick-robot
Copy link

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot commented Mar 26, 2024 •
edited by alculquicondor

This is an automated cherry-pick of #1897

/assign alculquicondor

Reduce number of Workload reconciliations due to wrong equality check.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Mar 26, 2024
Merged
@k8s-ci-robot k8s-ci-robot added this to the v0.6 milestone Mar 26, 2024
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 26, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 26, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 26, 2024 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit a7fd1bb
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6602d928909f7e000844505b

gabesaba and others added 3 commits March 26, 2024 14:18
@gabesaba
Dereference StopPolicy before equality check
ef413dc
@gabesaba @tenzen-y
Update pkg/controller/core/workload_controller.go
d9edcee 
Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@gabesaba @tenzen-y
Update pkg/controller/core/workload_controller.go
a7fd1bb 
Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@alculquicondor
Copy link
Contributor

/release-note-edit

Reduce number of Workload reconciliations

@k8s-ci-robot
Copy link
Contributor

@alculquicondor: /release-note-edit must be used with a release note block.

In response to this:

/release-note-edit

Reduce number of Workload reconciliations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alculquicondor
Copy link
Contributor

/release-note-edit

Reduce number of Workload reconciliations

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 26, 2024
@alculquicondor
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b08b1cf9136fccb3be504392af26b830f6770fd2

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, k8s-infra-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit 3968266 into kubernetes-sigs:release-0.6 Mar 26, 2024
13 checks passed
@alculquicondor
Copy link
Contributor

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@trasc trasc Awaiting requested review from trasc

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.6
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@k8s-infra-cherrypick-robot @alculquicondor @k8s-ci-robot @gabesaba