Introduce AdmissionCheckStrategy API, change assigning AdmissionCheck… #1960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
PBundyra
force-pushed
the
admissioncheck-per-flavor
branch
from
fecc083
to
c755404
Compare
|
/assign @alculquicondor |
k8s-ci-robot
added
size/XL
|
/release-note-edit |
|
The original note could have been interpreted as a breaking change, which is not the case. |
|
/release-note-edit |
PBundyra
force-pushed
the
admissioncheck-per-flavor
branch
3 times, most recently
from
8237aa8
to
7c77a63
Compare
tenzen-y
reviewed
Apr 10, 2024
mimowo
reviewed
Apr 10, 2024
PBundyra
force-pushed
the
admissioncheck-per-flavor
branch
6 times, most recently
from
0992e5b
to
dbdc4a2
Compare
PBundyra
force-pushed
the
admissioncheck-per-flavor
branch
2 times, most recently
from
478a256
to
18dd2fa
Compare
|
/retest |
|
If the above error is a flaky, please open an issue. |
k8s-ci-robot
added
the
needs-rebase
PBundyra
force-pushed
the
admissioncheck-per-flavor
branch
from
e03ee55
to
ccc1b3a
Compare
k8s-ci-robot
removed
the
needs-rebase
PBundyra
force-pushed
the
admissioncheck-per-flavor
branch
3 times, most recently
from
2da7665
to
81067e7
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, PBundyra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
…s to a Workload
Add validation webhook
Add TestReconcile unit tests
Add webhook unit tests
Add an additional layer to the API that wraps rules for AdmissionChecks
Add AdmissionCheckStrategy to ClusterQueues's cache
Change ClusterQueue cache
Sort AdmissionChecks in a Workload
PBundyra
force-pushed
the
admissioncheck-per-flavor
branch
from
81067e7
to
181cdca
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: bbfb53bfb4792ccaa7d3d14764d98b4e2c9e1d78
|
tenzen-y
reviewed
Apr 16, 2024
|
Oops, this PR already has been merged :( |
|
@PBundyra Sorry for my late response. Could you address my comments? Thanks. |
vsoch
pushed a commit
to researchapps/kueue
that referenced
this pull request
Apr 18, 2024
…s to a Workload (kubernetes-sigs#1960) Add validation webhook Add TestReconcile unit tests Add webhook unit tests Add an additional layer to the API that wraps rules for AdmissionChecks Add AdmissionCheckStrategy to ClusterQueues's cache Change ClusterQueue cache Sort AdmissionChecks in a Workload
|
/release-note-edit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s to a Workload
What type of PR is this?
/kind feature
What this PR does / why we need it:
Implements changes described in #1935
Which issue(s) this PR fixes:
Fixes #1432
Special notes for your reviewer:
I've tested it manually e2e. In an incoming PR I'll add webhook validation.
Does this PR introduce a user-facing change?