Make ClusterQueue's AdmissionCheckStrategy a pointer, avoid type casting #1993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
/assign @tenzen-y |
k8s-ci-robot
added
the
size/M
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
PBundyra
force-pushed
the
admissioncheck-per-flavor
branch
from
d3e6e97
to
3112eec
Compare
|
/remove-kind bug |
k8s-ci-robot
added
kind/cleanup
PBundyra
force-pushed
the
admissioncheck-per-flavor
branch
from
3dfa922
to
50f4793
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: PBundyra, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm cancel |
k8s-ci-robot
removed
the
lgtm
PBundyra
force-pushed
the
admissioncheck-per-flavor
branch
from
ee29e21
to
6dc4cde
Compare
k8s-ci-robot
added
size/L
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: aa8707df4a44c47b4159b0208b560776887b1eb1
|
vsoch
pushed a commit
to researchapps/kueue
that referenced
this pull request
Apr 18, 2024
…ing (kubernetes-sigs#1993) * Make AdmissionCheckStrategy a pointer, avoid type casting * Fix flaky integration test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Addresses comments of an already merged PR #1960
Which issue(s) this PR fixes:
Part of #1432
Special notes for your reviewer:
Does this PR introduce a user-facing change?