Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dep] Use jobset v0.5.0 #1984

Merged
merged 1 commit into from
Apr 16, 2024
Merged

[dep] Use jobset v0.5.0 #1984

merged 1 commit into from
Apr 16, 2024

Conversation

trasc
Copy link
Contributor

@trasc trasc commented Apr 16, 2024 •
edited

What type of PR is this?

What this PR does / why we need it:

[dep] Use jobset v0.5.0

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 16, 2024
@trasc
Copy link
Contributor Author

trasc commented Apr 16, 2024

/test all

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 16, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 16, 2024 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit da3cd18
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/661e0043609ca100080caafa
😎 Deploy Preview https://deploy-preview-1984--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@trasc
Copy link
Contributor Author

trasc commented Apr 16, 2024

/test pull-kueue-test-e2e-main-1-28
/test pull-kueue-test-e2e-main-1-27

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 16, 2024
@trasc trasc marked this pull request as ready for review April 16, 2024 05:57
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 16, 2024
@trasc
Copy link
Contributor Author

trasc commented Apr 16, 2024

/cc @tenzen-y
@mimowo , @tenzen-y can you have a quick look?

@tenzen-y
Copy link
Member

/test pull-kueue-test-e2e-main-1-28 /test pull-kueue-test-e2e-main-1-27

@trasc What is the reason that you restarted some CI jobs?

@trasc
Copy link
Contributor Author

trasc commented Apr 16, 2024

/test pull-kueue-test-e2e-main-1-28 /test pull-kueue-test-e2e-main-1-27

@trasc What is the reason that you restarted some CI jobs?

CI-job setup issues https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kueue/1984/pull-kueue-test-e2e-main-1-27/1780092894862905344

@trasc
Copy link
Contributor Author

trasc commented Apr 16, 2024

/test all

@tenzen-y
Copy link
Member

/test pull-kueue-test-e2e-main-1-28 /test pull-kueue-test-e2e-main-1-27

@trasc What is the reason that you restarted some CI jobs?

CI-job setup issues https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kueue/1984/pull-kueue-test-e2e-main-1-27/1780092894862905344

I see.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 16a0ffeb3feb1668887018f7414ab9e3c944569d

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y, trasc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit afc8e8f into kubernetes-sigs:main Apr 16, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.7 milestone Apr 16, 2024
@trasc trasc deleted the jobset-0.5 branch April 16, 2024 12:26
vsoch pushed a commit to researchapps/kueue that referenced this pull request Apr 18, 2024
@trasc @vsoch
[dep] Use jobset v0.5.0 (kubernetes-sigs#1984)
d1d424e
@alculquicondor alculquicondor mentioned this pull request May 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denkensk denkensk Awaiting requested review from denkensk

@mimowo mimowo Awaiting requested review from mimowo

@kerthcet kerthcet Awaiting requested review from kerthcet

@tenzen-y tenzen-y Awaiting requested review from tenzen-y

Assignees

@tenzen-y tenzen-y

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@trasc @k8s-ci-robot @tenzen-y