-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kueue might lose fields when admitting jobs #2269
Comments
/assign @PBundyra |
As a hotfix for jobset integration, we need to bump the version of jobset in the release-0.6 branch. We might have to do it manually #1984 |
intersting. Which job types did you observe this issue? |
jobset |
I see. It's only JobSet. Thanks. |
It could be anything, but jobset is the only API that is changing quite fast. |
That makes sense. |
/assign @mbobrovskyi |
/reopen |
@mimowo: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What happened:
Whenever Kueue APIs are a version behind the latest version for a particular job type, there is the risk of dropping fields, because of the use of
Update
.We should be using
Patch
instead.What you expected to happen:
Kueue to be resilient to upgrades of Job CRDs.
Anything else we need to know?:
Environment:
kubectl version
):git describe --tags --dirty --always
):cat /etc/os-release
):uname -a
):The text was updated successfully, but these errors were encountered: