Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use Patch instead of Update on jobframework." #2565

Conversation

mbobrovskyi
Copy link
Contributor

@mbobrovskyi mbobrovskyi commented Jul 9, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

Reverts #2501

Which issue(s) this PR fixes:

Part of #2269

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jul 9, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 9, 2024
Copy link

netlify bot commented Jul 9, 2024

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit fbd722b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/668d57c90faead00080b1060
😎 Deploy Preview https://deploy-preview-2565--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 9, 2024
@mbobrovskyi
Copy link
Contributor Author

/assign @alculquicondor

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jul 9, 2024
@alculquicondor
Copy link
Contributor

/release-note-edit

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 9, 2024
@alculquicondor
Copy link
Contributor

I'll just remove the release note from the previous PR too.

@alculquicondor
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 51216460908e23e5003374fc1fe1fbfddb0c634c

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, mbobrovskyi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2024
@tenzen-y
Copy link
Member

tenzen-y commented Jul 9, 2024

Just confirmations. What is the reason for reverting this change?

@alculquicondor
Copy link
Contributor

Because Update is strict (fails if resourceVersion is different), but Patch isn't.

#2553 was trying to fix this as a follow-up, but during review too many questions opened up about whether we are preserving the behavior. So I suggested that we revert the whole thing and put the 2 PRs into one.

@tenzen-y
Copy link
Member

tenzen-y commented Jul 9, 2024

Because Update is strict (fails if resourceVersion is different), but Patch isn't.

#2553 was trying to fix this as a follow-up, but during review too many questions opened up about whether we are preserving the behavior. So I suggested that we revert the whole thing and put the 2 PRs into one.

That makes sense. Thank you for the explanations!

@tenzen-y
Copy link
Member

tenzen-y commented Jul 9, 2024

due to insufficient computing

/retest

@k8s-ci-robot k8s-ci-robot merged commit e632fe7 into kubernetes-sigs:main Jul 9, 2024
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.8 milestone Jul 9, 2024
@mbobrovskyi mbobrovskyi deleted the revert-2501-fix/use-patch-instead-of-update-on-jobframework branch July 9, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants