-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Use Patch instead of Update on jobframework." #2565
Revert "Use Patch instead of Update on jobframework." #2565
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/assign @alculquicondor |
/release-note-edit
|
I'll just remove the release note from the previous PR too. |
/lgtm |
LGTM label has been added. Git tree hash: 51216460908e23e5003374fc1fe1fbfddb0c634c
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, mbobrovskyi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Just confirmations. What is the reason for reverting this change? |
Because Update is strict (fails if resourceVersion is different), but Patch isn't. #2553 was trying to fix this as a follow-up, but during review too many questions opened up about whether we are preserving the behavior. So I suggested that we revert the whole thing and put the 2 PRs into one. |
That makes sense. Thank you for the explanations! |
due to insufficient computing /retest |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Reverts #2501
Which issue(s) this PR fixes:
Part of #2269
Special notes for your reviewer:
Does this PR introduce a user-facing change?