-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use patch instead of update on jobframework. #2553
Use patch instead of update on jobframework. #2553
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
1f47014
to
0165633
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a nit. cc @alculquicondor
0165633
to
e0146fc
Compare
/retest |
cf56865
to
4f3689b
Compare
/retest |
4f3689b
to
26ccd4a
Compare
I want to review the whole thing from the previous version. |
/hold |
26ccd4a
to
aeeb3ab
Compare
aeeb3ab
to
26b24b4
Compare
/hold cancel Due to #2566 already fixed. |
/retest Due to insufficient computing. |
2565b20
to
47d49ff
Compare
/retest Due to insufficient computing. |
/test pull-kueue-test-e2e-main-1-27 Due to #2581 |
47d49ff
to
430a9bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: 099ca25c315a841889c2fe48567b9820b2169f37
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, mbobrovskyi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Use
Patch
instead ofUpdate
on jobframework to prevent the risk of dropping fields.Which issue(s) this PR fixes:
Fixes #2269
Special notes for your reviewer:
Follow up for #2501 (comment).
Does this PR introduce a user-facing change?