Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Patch instead of Update on jobframework. #2501

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Use Patch instead of Update on jobframework. #2501

merged 1 commit into from
Jul 8, 2024

Conversation

mbobrovskyi
Copy link
Contributor

@mbobrovskyi mbobrovskyi commented Jun 28, 2024 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

Use Patch instead of Update on jobframework to prevent the risk of dropping fields.

Which issue(s) this PR fixes:

Fixes #2269

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 28, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 28, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 28, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit f3d4347
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/668b97f34021f6000845f4fa

@mbobrovskyi mbobrovskyi marked this pull request as draft June 28, 2024 15:35
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 28, 2024
@mbobrovskyi mbobrovskyi force-pushed the fix/use-patch-instead-of-update-on-jobframework branch from ee00136 to 0674ffb Compare June 29, 2024 04:27
@mbobrovskyi
Copy link
Contributor Author

/test all

@mbobrovskyi mbobrovskyi marked this pull request as ready for review June 29, 2024 04:40
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 29, 2024
trasc
trasc reviewed Jul 1, 2024
View reviewed changes
Copy link
Contributor

@trasc trasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8aab9d9f65a705daa3388935df933a7c6e44ef80

@trasc
Copy link
Contributor

trasc commented Jul 2, 2024

/assign @alculquicondor

@alculquicondor
Copy link
Contributor

/unassign
/assign @mimowo

@k8s-ci-robot k8s-ci-robot assigned mimowo and unassigned alculquicondor Jul 5, 2024
mimowo
mimowo reviewed Jul 8, 2024
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit.

pkg/controller/jobs/job/job_controller.go Show resolved Hide resolved
pkg/controller/jobs/job/job_controller.go Outdated Show resolved Hide resolved
@mbobrovskyi mbobrovskyi force-pushed the fix/use-patch-instead-of-update-on-jobframework branch from 0674ffb to ade6d48 Compare July 8, 2024 07:35
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 8, 2024
@k8s-ci-robot k8s-ci-robot requested review from mimowo and trasc July 8, 2024 07:35
@mbobrovskyi mbobrovskyi force-pushed the fix/use-patch-instead-of-update-on-jobframework branch from ade6d48 to f3d4347 Compare July 8, 2024 07:40
@mimowo
Copy link
Contributor

mimowo commented Jul 8, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 8, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1cf0c62743868204459afa4847f7d4ce0bae3564

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbobrovskyi, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2024
@mbobrovskyi
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 4d89521 into kubernetes-sigs:main Jul 8, 2024
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.8 milestone Jul 8, 2024
@mbobrovskyi mbobrovskyi deleted the fix/use-patch-instead-of-update-on-jobframework branch July 8, 2024 08:28
@mbobrovskyi mbobrovskyi mentioned this pull request Jul 8, 2024
Merged
@mimowo
Copy link
Contributor

mimowo commented Jul 9, 2024

/reopen
Let's keep it open to keep track of the outstanding work in #2553 which is not just cleanup but also semantic change from non-strict to strict patches.

@k8s-ci-robot
Copy link
Contributor

@mimowo: Failed to re-open PR: state cannot be changed. The pull request cannot be reopened.

In response to this:

/reopen
Let's keep it open to keep track of the outstanding work in #2553 which is not just cleanup but also semantic change from non-strict to strict patches.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

mbobrovskyi added a commit to epam/kubernetes-kueue that referenced this pull request Jul 9, 2024
@mbobrovskyi
Revert "Use patch instead of update on jobframework. (kubernetes-sigs…
fbd722b 
…#2501)"

This reverts commit 4d89521.
@mbobrovskyi mbobrovskyi mentioned this pull request Jul 9, 2024
Merged
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 9, 2024
@alculquicondor
Copy link
Contributor

/release-note-edit

NONE

Because it was reverted in #2565

k8s-ci-robot pushed a commit that referenced this pull request Jul 9, 2024
@mbobrovskyi
Revert "Use patch instead of update on jobframework. (#2501)" (#2565)
e632fe7 
This reverts commit 4d89521.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@denkensk denkensk Awaiting requested review from denkensk

@mimowo mimowo Awaiting requested review from mimowo

@trasc trasc Awaiting requested review from trasc

Assignees

@mimowo mimowo

@trasc trasc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.8
Development

Successfully merging this pull request may close these issues.

Kueue might lose fields when admitting jobs
5 participants
@mbobrovskyi @k8s-ci-robot @trasc @alculquicondor @mimowo