Upgrade to jobset v0.5.1 APIs #2271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
alculquicondor
force-pushed
the
upgrade-jobset
branch
from
96d8cbe
to
c1eb121
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 60b18cea69dc235bf0716dd32c36dd264b0749b5
|
|
/retest |
|
Turns out we also need #1819 |
|
/retest |
|
/test pull-kueue-test-unit-release-0-6 |
|
/test pull-kueue-verify-release-0-6 |
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Change-Id: I9659013e2cf1fd40d5de90d029ad5b738be54c41
alculquicondor
force-pushed
the
upgrade-jobset
branch
from
c1eb121
to
c096a7c
Compare
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
removed
the
needs-rebase
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: d4d138df4c7b30743e83e76db8bb10490b09c248
|
tenzen-y
pushed a commit
to tenzen-y/kueue
that referenced
this pull request
May 26, 2024
Change-Id: I9659013e2cf1fd40d5de90d029ad5b738be54c41 Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Because Kueue uses
Updatewhen unsuspending jobsets, it can drop immutable fields from a jobset.Upgrading to the latest APIs is backwards compatible.
Which issue(s) this PR fixes:
Part of #2269
Special notes for your reviewer:
Does this PR introduce a user-facing change?