Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): wrong secret name in certificate #2087

Merged

Conversation

EladDolev
Copy link
Contributor

@EladDolev EladDolev commented Apr 28, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

Without these changes the integration with cert-manager is not working

Does this PR introduce a user-facing change?

Helm: Fix a bug that prevented Kueue to work with the cert-manager.

Signed-off-by: Elad Dolev <dolevelad@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. labels Apr 28, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 28, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @EladDolev. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 28, 2024
Copy link

netlify bot commented Apr 28, 2024

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit f74bb7a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/662e6881da278300081c8b13
😎 Deploy Preview https://deploy-preview-2087--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tenzen-y
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 29, 2024
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3c15e2163a231a80eef336e21515e7fed2c753b8

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EladDolev, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2024
@tenzen-y
Copy link
Member

/release-note-edit

Helm Chart: Fix a bug that the kueue does not work with the cert-manager.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Apr 29, 2024
@tenzen-y
Copy link
Member

/cherry-pick release-0.6

@k8s-infra-cherrypick-robot

@tenzen-y: once the present PR merges, I will cherry-pick it on top of release-0.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit b5d3b4d into kubernetes-sigs:main Apr 29, 2024
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.7 milestone Apr 29, 2024
@k8s-infra-cherrypick-robot

@tenzen-y: #2087 failed to apply on top of branch "release-0.6":

Applying: fix(helm): wrong secret name in certificate
Using index info to reconstruct a base tree...
M	charts/kueue/templates/certmanager/certificate.yaml
M	charts/kueue/templates/internalcert/secret.yaml
Falling back to patching base and 3-way merge...
Auto-merging charts/kueue/templates/internalcert/secret.yaml
CONFLICT (content): Merge conflict in charts/kueue/templates/internalcert/secret.yaml
Auto-merging charts/kueue/templates/certmanager/certificate.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix(helm): wrong secret name in certificate
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-0.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tenzen-y
Copy link
Member

@EladDolev Could you create a cherry-pick PR? This script would be helpful.

@EladDolev
Copy link
Contributor Author

Hi @tenzen-y and thanks for your help 🙏
Have opened this PR using the tool. Hope that's okay

@alculquicondor
Copy link
Contributor

/release-note-edit

Helm: Fix a bug that prevented Kueue to work with the cert-manager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants