Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #2087: fix(helm): wrong secret name in certificate #2098

Merged
merged 1 commit into from
May 8, 2024
Merged

Automated cherry pick of #2087: fix(helm): wrong secret name in certificate #2098

merged 1 commit into from
May 8, 2024

Conversation

EladDolev
Copy link
Contributor

@EladDolev EladDolev commented Apr 29, 2024 •
edited by k8s-ci-robot

Cherry pick of #2087 on release-0.6.
#2087: fix(helm): wrong secret name in certificate
For details on the cherry pick process, see the cherry pick requests page.

Helm Chart: Fix a bug that the kueue does not work with the cert-manager.

@k8s-ci-robot k8s-ci-robot added this to the v0.6 milestone Apr 29, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 29, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @EladDolev. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 29, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 29, 2024 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 26ef04c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/663b18a8e544d60008a67352

@EladDolev EladDolev mentioned this pull request Apr 29, 2024
Merged
tenzen-y
tenzen-y reviewed Apr 29, 2024
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

charts/kueue/templates/internalcert/secret.yaml Outdated
Comment on lines 7 to 8
labels:
{{- include "kueue.labels" . | nindent 4 }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
labels:
{{- include "kueue.labels" . | nindent 4 }}

Could you remove these lines since these changes are irrelevant to this commit?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EladDolev friendly ping

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed @tenzen-y
thank you 🙏

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 29, 2024
@tenzen-y
Copy link
Member

/release-note-edit

Helm Chart: Fix a bug that the kueue does not work with the cert-manager.

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 29, 2024
@EladDolev
fix(helm): wrong secret name in certificate
26ef04c 
Signed-off-by: Elad Dolev <dolevelad@gmail.com>
@EladDolev EladDolev force-pushed the automated-cherry-pick-of-#2087-upstream-release-0.6 branch from 52da760 to 26ef04c Compare May 8, 2024 06:16
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 8, 2024
tenzen-y
tenzen-y reviewed May 8, 2024
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3cda77325b52338b6933ed9f385ba01dc4acef99

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EladDolev, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2024
@k8s-ci-robot k8s-ci-robot merged commit 62e9dc9 into kubernetes-sigs:release-0.6 May 8, 2024
13 checks passed
@alculquicondor
Copy link
Contributor

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@denkensk denkensk Awaiting requested review from denkensk

@mimowo mimowo Awaiting requested review from mimowo

Assignees

@tenzen-y tenzen-y

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.6
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@EladDolev @k8s-ci-robot @tenzen-y @alculquicondor