Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kueuectl] Added validation for ClusterQueue on creating LocalQueue. #2122

Merged
merged 1 commit into from
May 8, 2024
Merged

[kueuectl] Added validation for ClusterQueue on creating LocalQueue. #2122

merged 1 commit into from
May 8, 2024

Conversation

mbobrovskyi
Copy link
Contributor

@mbobrovskyi mbobrovskyi commented May 3, 2024 •
edited by k8s-ci-robot

What type of PR is this?

/kind feature

What this PR does / why we need it:

To prevent the creation of a localqueue if a clusterqueue not exist.

Which issue(s) this PR fixes:

Fixes #2112

Special notes for your reviewer:

Does this PR introduce a user-facing change?

CLI: Add validation for ClusterQueue on creating LocalQueue

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels May 3, 2024
@k8s-ci-robot k8s-ci-robot requested review from mimowo and trasc May 3, 2024 20:15
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 3, 2024
@netlify Netlify
Copy link

netlify bot commented May 3, 2024 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 1bf25b9
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/663545eb21ecc00008b959bb
😎 Deploy Preview https://deploy-preview-2122--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mbobrovskyi
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 3, 2024
@mbobrovskyi mbobrovskyi marked this pull request as ready for review May 3, 2024 20:28
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 3, 2024
@mbobrovskyi
Copy link
Contributor Author

/cc @alculquicondor

@alculquicondor
Copy link
Contributor

/assign @mwielgus

@mbobrovskyi
Copy link
Contributor Author

/assign @trasc

trasc
trasc reviewed May 8, 2024
View reviewed changes
Copy link
Contributor

@trasc trasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bb00c19205c2c58ba5ff9fb1fb89d4a5bc9c464e

mwielgus
mwielgus approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mbobrovskyi
Copy link
Contributor Author

/assign @alculquicondor

alculquicondor
alculquicondor reviewed May 8, 2024
View reviewed changes
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, mbobrovskyi, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2024
@k8s-ci-robot
Copy link
Contributor

@mbobrovskyi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kueue-test-scheduling-perf-main 1bf25b9 link unknown /test pull-kueue-test-scheduling-perf-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mbobrovskyi
Copy link
Contributor Author

/test pull-kueue-test-scheduling-perf-main

@k8s-ci-robot k8s-ci-robot merged commit 0caf8ba into kubernetes-sigs:main May 8, 2024
14 of 15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.7 milestone May 8, 2024
@mbobrovskyi mbobrovskyi deleted the feature/add-validation-for-clusterqueue-on-creating-localqueue branch May 8, 2024 18:34
@alculquicondor
Copy link
Contributor

/release-note-edit

CLI: Add validation for ClusterQueue on creating LocalQueue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@trasc trasc trasc left review comments

@mwielgus mwielgus mwielgus approved these changes

@mimowo mimowo Awaiting requested review from mimowo

@denkensk denkensk Awaiting requested review from denkensk

Assignees

@alculquicondor alculquicondor

@mwielgus mwielgus

@trasc trasc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.

[kueuectl] Add validation for ClusterQueue on creating LocalQueue
5 participants
@mbobrovskyi @k8s-ci-robot @alculquicondor @mwielgus @trasc