Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add limit to the retry period for re-queing workloads #2264

Merged
merged 6 commits into from
May 24, 2024
Merged

Add limit to the retry period for re-queing workloads #2264

merged 6 commits into from
May 24, 2024

Conversation

IrvingMg
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds the BackoffMaxSeconds property to RequeuingStrategy so that a limit can be set to the retry period.

Which issue(s) this PR fixes:

Fixes #2216

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Adds the `BackoffMaxSeconds` property to limit the retry period length for re-queing workloads.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 22, 2024
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 22, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 22, 2024
@netlify Netlify
Copy link

netlify bot commented May 22, 2024 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit a489bdd
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/665045a6836cae00080fc1c5

@IrvingMg IrvingMg force-pushed the feature/limit-retry-period-waitforpodsready branch from bf5b664 to 9bb27b8 Compare May 22, 2024 22:03
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 22, 2024
@IrvingMg
Copy link
Contributor Author

/test all

@IrvingMg
Copy link
Contributor Author

/assign @trasc

trasc
trasc reviewed May 23, 2024
View reviewed changes
pkg/config/validation.go Outdated Show resolved Hide resolved
trasc
trasc reviewed May 23, 2024
View reviewed changes
Copy link
Contributor

@trasc trasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b4345fdf2b72f1ca8a0baf6331ee4f4525652461

@IrvingMg IrvingMg marked this pull request as ready for review May 23, 2024 11:14
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 23, 2024
mimowo
mimowo reviewed May 23, 2024
View reviewed changes
pkg/controller/core/workload_controller.go Outdated Show resolved Hide resolved
pkg/controller/core/workload_controller.go Outdated Show resolved Hide resolved
apis/config/v1beta1/configuration_types.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2024
@k8s-ci-robot k8s-ci-robot requested a review from trasc May 23, 2024 15:36
@IrvingMg IrvingMg force-pushed the feature/limit-retry-period-waitforpodsready branch from b7acd9f to ce6ef21 Compare May 23, 2024 17:20
@IrvingMg IrvingMg force-pushed the feature/limit-retry-period-waitforpodsready branch from ce6ef21 to 373bc17 Compare May 23, 2024 17:32
@alculquicondor
Copy link
Contributor

/approve
for API
/hold
Leaving LGTM to @mimowo

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 23, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, IrvingMg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2024
mimowo
mimowo reviewed May 24, 2024
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost lgtm, one pending comment

pkg/controller/core/workload_controller.go Outdated Show resolved Hide resolved
mimowo
mimowo reviewed May 24, 2024
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 03c1845c1a7e52d4bd5cea9e67647c800f3b8142

@trasc
Copy link
Contributor

trasc commented May 24, 2024

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 24, 2024
@k8s-ci-robot k8s-ci-robot merged commit 1ead052 into kubernetes-sigs:main May 24, 2024
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.7 milestone May 24, 2024
@IrvingMg IrvingMg deleted the feature/limit-retry-period-waitforpodsready branch May 28, 2024 11:34
@tenzen-y tenzen-y mentioned this pull request May 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimowo mimowo mimowo left review comments

@kerthcet kerthcet Awaiting requested review from kerthcet

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@denkensk denkensk Awaiting requested review from denkensk

@trasc trasc Awaiting requested review from trasc

Assignees

@mimowo mimowo

@trasc trasc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.

Limit the retry period length in waitForPodsReady
5 participants
@IrvingMg @k8s-ci-robot @alculquicondor @trasc @mimowo