-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WaitForPodsReady: Add documentation for the backoffMaxSeconds #2327
WaitForPodsReady: Add documentation for the backoffMaxSeconds #2327
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/assign @alculquicondor |
@@ -77,9 +78,15 @@ When the `blockAdmission` is set to `true`, admitted Workload with not ready pod | |||
{{% alert title="Warning" color="warning" %}} | |||
_Available in Kueue v0.6.0 and later_ | |||
{{% /alert %}} | |||
{{% alert title="Note" color="primary" %}} | |||
_The `backoffBaseSeconds` and `backodMaxSeconds` are available in Kueue v0.7.0 and later_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_The `backoffBaseSeconds` and `backodMaxSeconds` are available in Kueue v0.7.0 and later_ | |
The `backoffBaseSeconds` and `backodMaxSeconds` are available in Kueue v0.7.0 and later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
- `timestamp` (`waitForPodsReady.requeuingStrategy.timestamp`) | ||
- `backoffLimitCount` (`waitForPodsReady.requeuingStrategy.backoffLimitCount`) | ||
- `backoffBaseSeconds` (`waitForPodsReady.requeuingStrategy.backoffBaseSeconds`) | ||
- `backoffMaxSeconds` (`waitForPodsReady.requeuingStrategy.backoffMaxSeconds`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- `timestamp` (`waitForPodsReady.requeuingStrategy.timestamp`) | |
- `backoffLimitCount` (`waitForPodsReady.requeuingStrategy.backoffLimitCount`) | |
- `backoffBaseSeconds` (`waitForPodsReady.requeuingStrategy.backoffBaseSeconds`) | |
- `backoffMaxSeconds` (`waitForPodsReady.requeuingStrategy.backoffMaxSeconds`) | |
- `timestamp` | |
- `backoffLimitCount` | |
- `backoffBaseSeconds` | |
- `backoffMaxSeconds` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
`backoffBaseSeconds` parameter (defaulting to 60). So, after the consecutive timeouts | ||
the evicted workload is re-queued after approximately `60, 120, 240, ...` seconds. | ||
the evicted workload is re-queued after approximately `60, 120, 240, ..., 3600, 3600 ..., 3600` seconds | ||
if you don't specify the maximum backoff time by the `backoffMaxSeconds` (defaulting to 3600). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`backoffBaseSeconds` parameter (defaulting to 60). You can configure the maximum
backoff time by setting `backoffMaxSeconds` (defaulting to 3600). Using the defaults, the
evicted workload is re-queued after approximately `60, 120, 240, ..., 3600, ..., 3600` seconds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for great suggestion!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
the evicted workload is re-queued after approximately `60, 120, 240, ...` seconds. | ||
the evicted workload is re-queued after approximately `60, 120, 240, ..., 3600, 3600 ..., 3600` seconds | ||
if you don't specify the maximum backoff time by the `backoffMaxSeconds` (defaulting to 3600). | ||
Even if the backoff time reaches the `backoffMaxSeconds`, Kueue will keep to re-queue an evicted Workload with the `backoffMaxSeconds` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if the backoff time reaches the `backoffMaxSeconds`, Kueue will keep to re-queue an evicted Workload with the `backoffMaxSeconds` | |
Even if the backoff time reaches the `backoffMaxSeconds`, Kueue will continue to re-queue an evicted Workload with the `backoffMaxSeconds` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
702f9ff
to
b7a4e83
Compare
@alculquicondor I addressed all comments. PTAL, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 54615eb5d71c5f90d13dd4a32e2dcd82d029ecc2
|
What type of PR is this?
/kind documentation
What this PR does / why we need it:
We don't have any documentation about #2264.
Which issue(s) this PR fixes:
Part-of #2216
Special notes for your reviewer:
Does this PR introduce a user-facing change?