Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace kubectl Containers tab with Logs tab #4603

Closed
starpit opened this issue May 15, 2020 · 3 comments · Fixed by #4622
Closed

replace kubectl Containers tab with Logs tab #4603

starpit opened this issue May 15, 2020 · 3 comments · Fixed by #4622
Labels
8_7_x affecting the 8_7_x stability branch

Comments

@starpit
Copy link
Contributor

starpit commented May 15, 2020

and then remove Show Logs button
@starpit starpit added the 8_7_x affecting the 8_7_x stability branch label May 15, 2020
@hanqiuzh
Copy link
Contributor

Will this feature also move the logs from REPL area into the sidecar?

@starpit
Copy link
Contributor Author

starpit commented May 15, 2020

i think so!

@starpit starpit mentioned this issue May 15, 2020
Closed
starpit added a commit to starpit/kui that referenced this issue May 17, 2020
@starpit
fix: replace Containers with Logs tab
f9e23dc 
this PR also fixes
- a few missing pieces to support Sidecar Toolbar updates from react components
- ability for PTY streaming consumers to direct xon/xoff flow control
- removes a number of way out of date css rules

Fixes kubernetes-sigs#4603
@starpit starpit mentioned this issue May 17, 2020
Merged
7 tasks
starpit added a commit that referenced this issue May 17, 2020
@starpit
fix: replace Containers with Logs tab
00e8786 
this PR also fixes
- a few missing pieces to support Sidecar Toolbar updates from react components
- ability for PTY streaming consumers to direct xon/xoff flow control
- removes a number of way out of date css rules

Fixes #4603
@starpit
Copy link
Contributor Author

starpit commented May 18, 2020

forgot to remove the old Show Logs registration

@starpit starpit reopened this May 18, 2020
starpit added a commit to starpit/kui that referenced this issue May 18, 2020
@starpit
fix(plugins/plugin-kubectl): remove Show Logs registration
9c16216 
Fixes kubernetes-sigs#4603
starpit added a commit to starpit/kui that referenced this issue May 18, 2020
@starpit
fix(plugins/plugin-kubectl): remove Show Logs registration
f28aca6 
Fixes kubernetes-sigs#4603
starpit added a commit to starpit/kui that referenced this issue May 18, 2020
@starpit
fix: replace Containers with Logs tab
1e3b00d 
this PR also fixes
- a few missing pieces to support Sidecar Toolbar updates from react components
- ability for PTY streaming consumers to direct xon/xoff flow control
- removes a number of way out of date css rules

Fixes kubernetes-sigs#4603
starpit added a commit to starpit/kui that referenced this issue May 18, 2020
@starpit
fix(plugins/plugin-kubectl): remove Show Logs registration
48f55e9 
Fixes kubernetes-sigs#4603
starpit added a commit that referenced this issue May 19, 2020
@starpit
fix: replace Containers with Logs tab
3965f87 
this PR also fixes
- a few missing pieces to support Sidecar Toolbar updates from react components
- ability for PTY streaming consumers to direct xon/xoff flow control
- removes a number of way out of date css rules

Fixes #4603
starpit added a commit that referenced this issue May 19, 2020
@starpit
fix(plugins/plugin-kubectl): remove Show Logs registration
a53b476 
Fixes #4603
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
8_7_x affecting the 8_7_x stability branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: replace Containers with Logs tab starpit/kui
2 participants
@starpit @hanqiuzh