Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace Containers with Logs tab #4622

Merged
merged 1 commit into from
May 17, 2020

Conversation

starpit
Copy link
Contributor

@starpit starpit commented May 17, 2020

this PR also fixes

  • a few missing pieces to support Sidecar Toolbar updates from react components
  • ability for PTY streaming consumers to direct xon/xoff flow control
  • removes a number of way out of date css rules

Fixes #4603

Description of what you did:

My PR is a:

  • 💥 Breaking change
  • 🐛 Bug fix
  • 💅 Enhancement
  • 🚀 New feature

Please confirm that your PR fulfills these requirements

  • Multiple commits are squashed into one commit.
  • The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
  • All npm dependencies are pinned.

this PR also fixes
- a few missing pieces to support Sidecar Toolbar updates from react components
- ability for PTY streaming consumers to direct xon/xoff flow control
- removes a number of way out of date css rules

Fixes kubernetes-sigs#4603
@starpit starpit merged commit 00e8786 into kubernetes-sigs:master May 17, 2020
@starpit starpit deleted the fix-4603 branch May 17, 2020 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace kubectl Containers tab with Logs tab
1 participant