-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change release flow from using goreleaser to build scripts #5239
change release flow from using goreleaser to build scripts #5239
Conversation
Skipping CI for Draft Pull Request. |
0b9fdd5
to
b24f59a
Compare
4956157
to
2df2fed
Compare
2df2fed
to
b3a65c5
Compare
I try to publish in my fork: https://github.com/koba1t/kustomize/releases/tag/kustomize%2Fv5.0.0 |
b3a65c5
to
5bb1d64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good. Couple comments below.
Thanks for trying out the release on your fork. Could you also try out releasing api
, kyaml
and cmd/config
on your fork so we can verify that those work well too? Thank you so much.
additional_release_artifacts_arg="" | ||
|
||
# build `kustomize` binary | ||
if [[ "$module" == "kustomize" ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to confirm the behavior:
- If it is a kustomize release, then it will build and release the kustomize binary
- For other modules like kyaml, it will just create a new release based on the published tag.
Is that right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your understanding is entirely correct!
Please check the details for the below releases!
releasing/create-release.sh
Outdated
# build date in ISO8601 format | ||
build_date=$(date -u +'%Y-%m-%dT%H:%M:%SZ') | ||
for os in linux darwin windows; do | ||
for arch in amd64 arm64; do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a couple other architectures for linux that we currently release for, linux s390x and linux ppc64le. You can see these on our releases, such as this one: https://github.com/kubernetes-sigs/kustomize/releases/tag/kustomize%2Fv5.0.1
Can we include s390x and ppc64le for linux here as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5bb1d64
to
c7a2866
Compare
c7a2866
to
b1717c8
Compare
No problem! api: https://github.com/koba1t/kustomize/releases/tag/api%2Fv0.14.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Excited to try this out :) Thank you very much for working on this.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: koba1t, natasha41575 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
FYI this seems to have introduced: |
fix: #5220