Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kustomize 5.2.1 #1

Closed

Conversation

Mitsuwa
Copy link

@Mitsuwa Mitsuwa commented Oct 25, 2023

What

This Adds kustomize 5.2.1 releases to the toolchains https://github.com/kubernetes-sigs/kustomize/releases/tag/kustomize%2Fv5.2.1

It seems that the kustomize folks have changed the windows builds to be zip files instead of tar.gz is that going to break anything on this newer version?

I also need this pr because the latest version 5.1.0 available in the toolchains does not include arm64 macos, which I am now using

INFO: ToolchainResolution:   Type @rules_kustomize~0.3.5//tools/kustomize:toolchain_type: target platform @local_config_platform//:host: No toolchains found.
ERROR: /Users/bnobuhara/src/bt/infra-apps/examples/config/kubernetes/BUILD.bazel:68:21: While resolving toolchains for target //examples/config/kubernetes:kubernetes_upstream_kustomized_resources: No matching toolchains found for types @rules_kustomize~0.3.5//tools/kustomize:toolchain_type.
To debug, rerun with --toolchain_resolution_debug='@rules_kustomize~0.3.5//tools/kustomize:toolchain_type'
If platforms or toolchains are a new concept for you, we'd encourage reading https://bazel.build/concepts/platforms-intro.
$ bazel query --output=build @local_config_platform//:host
# /private/var/tmp/_bazel_bnobuhara/d28b21fbdd8288426ba7b73c2dda9527/external/local_config_platform/BUILD.bazel:4:9
platform(
  name = "host",
  constraint_values = ["@platforms~0.0.6//cpu:aarch64", "@platforms~0.0.6//os:osx"],
)
$ sha256sum ~/Downloads/kustomize_v5.2.1_*
b7aba749da75d33e6fea49a5098747d379abc45583ff5cd16e2356127a396549  /Users/bnobuhara/Downloads/kustomize_v5.2.1_darwin_amd64.tar.gz
f6a5f3cffd45bac585a0c80b5ed855c2b72d932a1d6e8e7c87aae3be4eba5750  /Users/bnobuhara/Downloads/kustomize_v5.2.1_darwin_arm64.tar.gz
88346543206b889f9287c0b92c70708040ecd5aad54dd33019c4d6579cd24de8  /Users/bnobuhara/Downloads/kustomize_v5.2.1_linux_amd64.tar.gz
5566f7badece5a72d42075d8dffa6296a228966dd6ac2390de7afbb9675c3aaa  /Users/bnobuhara/Downloads/kustomize_v5.2.1_linux_arm64.tar.gz
870ccb282cb3404c471a7f270299ae0cf1310f354822b8c0a626f1edd0b3dcff  /Users/bnobuhara/Downloads/kustomize_v5.2.1_windows_amd64.zip
ef5b2953cf792fa0118429c090113f697aca1810f6d5015838ad0917351ade9d  /Users/bnobuhara/Downloads/kustomize_v5.2.1_windows_arm64.zip

@Mitsuwa
Copy link
Author

Mitsuwa commented Oct 25, 2023

@seh please have a look

@seh
Copy link
Owner

seh commented Oct 30, 2023

Please see commits 53b8911 and c26337c, subsuming the change proposed here to include the latest Helm release as well. That's available via the BCR as version 0.3.6.

I discovered only by way of the BCR pre-submit CI workflows that the kustomize project's recent change to use goreleaser (per kubernetes-sigs/kustomize#5239, addressing kubernetes-sigs/kustomize#5220 and kubernetes-sigs/kustomize#5116) required further adjustment to the repository rule that downloads and allows invoking these released tools.

@seh seh closed this Oct 30, 2023
@seh seh self-assigned this Oct 30, 2023
@Mitsuwa
Copy link
Author

Mitsuwa commented Oct 30, 2023

ty steve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants