-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for config IP when genegrate pki certificate #636
Conversation
|
Welcome @forgocode! |
Hi @forgocode. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
✅ Deploy Preview for k8s-kwok ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
Please rebase this branch and don't merge the main into your branch. |
I have refactored this section to get all the IPs that may be accessed when creating the cluster and add them to the credentials, I think this should temporarily alleviate your problem, can you test it #642? The fields you added in this PR are also necessary in the case of access through the domain. |
yes, it #642 works, now i can access to apiserver by physical IP. |
please fix pull-kwok-verify-main https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kwok/636/pull-kwok-verify-main/1667430266894815232
|
Please rebase this branch and don't merge the main into your branch. |
Or do you want to wait until I merge PR #642, then rebase this PR, which should make this PR easier |
Please follow your plan, git is unfamiliar for me because i always use svn in the past. This is a great chance for me to practice git。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
Thank you for your contribution
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: forgocode, wzshiming The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I get so more knowledge about golang project and git, thanks for your guidance. By the way, can you provide a doc for developer about what should do when he/she want to contribue for this project. Example, how to check code format or if need to generate md files again. |
Actually, it's already there, just not as detailed. |
Yes, i had read this page, but maybe it can be more detailed. |
Sure, if I had more time or someone can work on this. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: