Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for config IP when genegrate pki certificate #636

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Support for config IP when genegrate pki certificate #636

merged 1 commit into from
Jun 12, 2023

Conversation

ricky97gr
Copy link
Contributor

@ricky97gr ricky97gr commented Jun 3, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Add the kubeApiserverCertSANs field to the KwokctlConfiguration to add a SAN when creating the cluster.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 3, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 3, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: forgocode / name: Derek (d60280d)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 3, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @forgocode!

It looks like this is your first PR to kubernetes-sigs/kwok 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kwok has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 3, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @forgocode. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@netlify
Copy link

netlify bot commented Jun 3, 2023

Deploy Preview for k8s-kwok ready!

Name Link
🔨 Latest commit d60280d
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/6486db2bd7c75a00088b27ac
😎 Deploy Preview https://deploy-preview-636--k8s-kwok.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 3, 2023
Copy link
Member

@wzshiming wzshiming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

pkg/apis/internalversion/kwokctl_configuration_types.go Outdated Show resolved Hide resolved
pkg/kwokctl/runtime/binary/cluster.go Outdated Show resolved Hide resolved
pkg/kwokctl/cmd/create/cluster/cluster.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 3, 2023
@wzshiming
Copy link
Member

Please rebase this branch and don't merge the main into your branch.

@wzshiming
Copy link
Member

I have refactored this section to get all the IPs that may be accessed when creating the cluster and add them to the credentials, I think this should temporarily alleviate your problem, can you test it #642?

The fields you added in this PR are also necessary in the case of access through the domain.

@ricky97gr
Copy link
Contributor Author

ricky97gr commented Jun 9, 2023

I have refactored this section to get all the IPs that may be accessed when creating the cluster and add them to the credentials, I think this should temporarily alleviate your problem, can you test it #642?

The fields you added in this PR are also necessary in the case of access through the domain.

yes, it #642 works, now i can access to apiserver by physical IP.

@ricky97gr ricky97gr requested a review from wzshiming June 10, 2023 08:24
@wzshiming
Copy link
Member

@wzshiming
Copy link
Member

Please rebase this branch and don't merge the main into your branch.

pkg/kwokctl/pki/pki.go Outdated Show resolved Hide resolved
@wzshiming
Copy link
Member

Or do you want to wait until I merge PR #642, then rebase this PR, which should make this PR easier

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 12, 2023
@ricky97gr
Copy link
Contributor Author

Or do you want to wait until I merge PR #642, then rebase this PR, which should make this PR easier

Please follow your plan, git is unfamiliar for me because i always use svn in the past. This is a great chance for me to practice git。

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 12, 2023
Copy link
Member

@wzshiming wzshiming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Thank you for your contribution

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: forgocode, wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2023
@ricky97gr
Copy link
Contributor Author

/approve /lgtm

Thank you for your contribution

I get so more knowledge about golang project and git, thanks for your guidance. By the way, can you provide a doc for developer about what should do when he/she want to contribue for this project. Example, how to check code format or if need to generate md files again.

@wzshiming
Copy link
Member

wzshiming commented Jun 12, 2023

Actually, it's already there, just not as detailed.
https://kwok.sigs.k8s.io/docs/contributing

@ricky97gr
Copy link
Contributor Author

Actually, it's already there, just not as detailed. https://kwok.sigs.k8s.io/docs/contributing

Yes, i had read this page, but maybe it can be more detailed.

@k8s-ci-robot k8s-ci-robot merged commit 0c7d999 into kubernetes-sigs:main Jun 12, 2023
@wzshiming
Copy link
Member

Sure, if I had more time or someone can work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants