Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kwokctl] Refactor the pki and the subcommand 'get kubeconfig' #642

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

wzshiming
Copy link
Member

@wzshiming wzshiming commented Jun 8, 2023

What type of PR is this?

/kind cleanup
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

`kwokctl get kubeconfig` Support modifies host, user, group and insecureSkipTLSVerify.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. labels Jun 8, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 8, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2023
@netlify
Copy link

netlify bot commented Jun 8, 2023

Deploy Preview for k8s-kwok ready!

Name Link
🔨 Latest commit 40f237f
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/6486a2f961b92f00089cb829
😎 Deploy Preview https://deploy-preview-642--k8s-kwok.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 8, 2023
@wzshiming wzshiming force-pushed the clean/pki branch 15 times, most recently from 44a1e54 to 6b3083e Compare June 9, 2023 13:33
@wzshiming wzshiming force-pushed the clean/pki branch 4 times, most recently from 1b3b96b to 839dd98 Compare June 9, 2023 19:12
@wzshiming wzshiming force-pushed the clean/pki branch 8 times, most recently from eb3431f to f689dfc Compare June 12, 2023 01:55
@wzshiming wzshiming changed the title [WIP] Refactor the pki and the subcommand 'get kubeconfig' [kwokctl] Refactor the pki and the subcommand 'get kubeconfig' Jun 12, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 12, 2023
@wzshiming wzshiming merged commit 4e07c77 into kubernetes-sigs:main Jun 12, 2023
@wzshiming wzshiming deleted the clean/pki branch June 12, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants