-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install: create a RoleBinding for obtain delegated authentication #272
Conversation
@wangchen615 could you give it a try to see if it works? |
/retest |
Ping @wangchen615. Can you take some chance to verify this fix? |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
6182a5d
to
9ad010a
Compare
|
1 similar comment
|
9ad010a
to
04334eb
Compare
Thanks, @Huang-Wei , yes, this role is also needed. |
@denkensk could you help /lgtm this? |
/lgtm Thanks @Huang-Wei |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: denkensk, Huang-Wei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #271.
This PRs adds a RoleBinding to obtain delegated authentication which is defined in
extension-apiserver-authentication-reader/kube-system
.