Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rbac.yaml to avoid "Failed to watch" error #285

Closed
wants to merge 1 commit into from
Closed

Update rbac.yaml to avoid "Failed to watch" error #285

wants to merge 1 commit into from

Conversation

wangchen615
Copy link
Contributor

This is to resolve and close issue #271 .

This is to resolve and close issue #271 .
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 5, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @wangchen615. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 5, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wangchen615
To complete the pull request process, please assign ahg-g after the PR has been reviewed.
You can assign the PR to them by writing /assign @ahg-g in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 5, 2021
@wangchen615
Copy link
Contributor Author

/assign @Huang-Wei

@denkensk
Copy link
Member

denkensk commented Nov 5, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 5, 2021
@denkensk
Copy link
Member

denkensk commented Nov 5, 2021

/lgtm
Thanks @wangchen615

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2021
@Huang-Wei
Copy link
Contributor

@wangchen615 the root cause is the RBAC rules applied to the secondary scheduler doesn't fully "copy" the ones applied to default scheduler, in particular, access to configmap "extension-apiserver-authentication". This was fixed in the upstream by creating a RoleBinding: kubernetes/kubernetes#72491

So I think we should follow the same way here, instead of imposing a direct configmap access.

I raised PR #272 earlier, could you verify if it works?

@wangchen615
Copy link
Contributor Author

Ok, I will close this PR then.

same way here, instead of imposing a direct con

#272

@wangchen615 wangchen615 closed this Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants