-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: anyone should be any #736
docs: anyone should be any #736
Conversation
Problem: the comment and associated docs should say if there are not resources available needed for the group, the scheduler should not start any. Solution: update all references anyone->any. It could also be stated "not start any one" but "not start any" is a more natural way to say it Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Welcome @vsoch! |
Hi @vsoch. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-scheduler-plugins ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/ok-to-test I'm not a native english speaker, but this reads better and AFAIK is indeed the correct way |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Huang-Wei, vsoch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Problem: the comment and associated docs should say if there are not resources available needed for the group, the scheduler should not start any.
Solution: update all references anyone->any.
It could also be stated "not start any one" but "not start any" is a more natural way to say it
What type of PR is this?
/kind documentation
What this PR does / why we need it:
It's a subtle word choice mistake.
Which issue(s) this PR fixes:
None - did not open an issue for something so small.
Special notes for your reviewer:
Does this PR introduce a user-facing change?