Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: anyone should be any #736

Merged
merged 1 commit into from
May 23, 2024
Merged

docs: anyone should be any #736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apis/scheduling/v1alpha1/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,12 +136,12 @@ type PodGroup struct {
type PodGroupSpec struct {
// MinMember defines the minimal number of members/tasks to run the pod group;
// if there's not enough resources to start all tasks, the scheduler
// will not start anyone.
// will not start any.
MinMember int32 `json:"minMember,omitempty"`

// MinResources defines the minimal resource of members/tasks to run the pod group;
// if there's not enough resources to start all tasks, the scheduler
// will not start anyone.
// will not start any.
MinResources v1.ResourceList `json:"minResources,omitempty"`

// ScheduleTimeoutSeconds defines the maximal time of members/tasks to wait before run the pod group;
Expand Down
4 changes: 2 additions & 2 deletions config/crd/bases/scheduling.x-k8s.io_podgroups.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ spec:
minMember:
description: MinMember defines the minimal number of members/tasks
to run the pod group; if there's not enough resources to start all
tasks, the scheduler will not start anyone.
tasks, the scheduler will not start any.
format: int32
type: integer
minResources:
Expand All @@ -54,7 +54,7 @@ spec:
x-kubernetes-int-or-string: true
description: MinResources defines the minimal resource of members/tasks
to run the pod group; if there's not enough resources to start all
tasks, the scheduler will not start anyone.
tasks, the scheduler will not start any.
type: object
scheduleTimeoutSeconds:
description: ScheduleTimeoutSeconds defines the maximal time of members/tasks
Expand Down
4 changes: 2 additions & 2 deletions kep/42-podgroup-coscheduling/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,12 @@ We define a CRD name PodGroup to help schedule, its definition is as follows:
type PodGroupSpec struct {
// MinMember defines the minimal number of members/tasks to run the pod group;
// if there's not enough resources to start all tasks, the scheduler
// will not start anyone.
// will not start any.
MinMember uint32 `json:"minMember"`

// MinResources defines the minimal resource of members/tasks to run the pod group;
// if there's not enough resources to start all tasks, the scheduler
// will not start anyone.
// will not start any.
MinResources *v1.ResourceList `json:"minResources,omitempty"`

// ScheduleTimeoutSeconds defines the maximal time of members/tasks to wait before run the pod group;
Expand Down
4 changes: 2 additions & 2 deletions manifests/coscheduling/crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ spec:
minMember:
description: MinMember defines the minimal number of members/tasks
to run the pod group; if there's not enough resources to start all
tasks, the scheduler will not start anyone.
tasks, the scheduler will not start any.
format: int32
type: integer
minResources:
Expand All @@ -54,7 +54,7 @@ spec:
x-kubernetes-int-or-string: true
description: MinResources defines the minimal resource of members/tasks
to run the pod group; if there's not enough resources to start all
tasks, the scheduler will not start anyone.
tasks, the scheduler will not start any.
type: object
scheduleTimeoutSeconds:
description: ScheduleTimeoutSeconds defines the maximal time of members/tasks
Expand Down
4 changes: 2 additions & 2 deletions site/content/en/docs/kep/42-podgroup-coscheduling/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,12 @@ We define a CRD name PodGroup to help schedule, its definition is as follows:
type PodGroupSpec struct {
// MinMember defines the minimal number of members/tasks to run the pod group;
// if there's not enough resources to start all tasks, the scheduler
// will not start anyone.
// will not start any.
MinMember uint32 `json:"minMember"`

// MinResources defines the minimal resource of members/tasks to run the pod group;
// if there's not enough resources to start all tasks, the scheduler
// will not start anyone.
// will not start any.
MinResources *v1.ResourceList `json:"minResources,omitempty"`

// ScheduleTimeoutSeconds defines the maximal time of members/tasks to wait before run the pod group;
Expand Down