Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running kubelet v1.26 fixes (deprecated args) #259

Merged
merged 1 commit into from
Dec 22, 2022
Merged

Running kubelet v1.26 fixes (deprecated args) #259

merged 1 commit into from
Dec 22, 2022

Conversation

a4099181
Copy link
Contributor

Reason for PR:
Deprecated arguments removed: --log-dir=/var/log/kubelet --logtostderr=false

Requirements

  • Sqaush commits

@a4099181
Running kubelet v1.26 fixes (deprecated args)
52cb900 
Depreacated arguments removed: --log-dir=/var/log/kubelet --logtostderr=false
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 15, 2022
@github-actions github-actions bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 15, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 15, 2022
@Mik4sa Mik4sa mentioned this pull request Dec 19, 2022
Closed
fabi200123
fabi200123 approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@fabi200123 fabi200123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have also tested this. Indeed these arguments does not allow kubelet to start on k8s v1.26. @jsturtevant can you take a look as well?
For me it is /lgtm

@jsturtevant
Copy link
Contributor

I see they are marked as deprecated but I don't seem them being removed in the 1.26 docs (https://kubernetes.io/docs/reference/command-line-tools-reference/kubelet/)? Could you link to where they are removed and causing issues starting? Otherwise looks good.

@fabi200123
Copy link
Contributor

@jsturtevant They said here that --log-dir, --logtostderr and other flags will become deprecated in future. It also say that Kubernetes 1.26 (tentative): GA, deprecated flags get removed.
Also, @marosset @jayunit100 I believe you should check this one out as well

claudiubelu
claudiubelu reviewed Dec 22, 2022
View reviewed changes
kubeadm/scripts/PrepareNode.ps1
[version]$CurrentVersion = $($KubernetesVersion.Split("v") | Select -Index 1)
[version]$V1_24_Version = '1.24'
if ($CurrentVersion -lt $V1_24_Version) {
$cmd_commands = $cmd_commands + "--network-plugin=cni " + "--image-pull-progress-deadline=20m "
}
[version]$V1_26_Version = '1.26'
if ($CurrentVersion -lt $V1_26_Version) {
$cmd_commands += ("--log-dir=/var/log/kubelet ", "--logtostderr=false ")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: ideally, it would have been consistent if the $V1_24_Version check and appending above.

@claudiubelu
Copy link
Contributor

I see they are marked as deprecated but I don't seem them being removed in the 1.26 docs (https://kubernetes.io/docs/reference/command-line-tools-reference/kubelet/)? Could you link to where they are removed and causing issues starting? Otherwise looks good.

I see in the v1.26 release notes (https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.26.md): Legacy klog flags are no longer available. Only -v and -vmodule are still supported. (https://github.com/kubernetes/kubernetes/pull/112120, [@pohly](https://github.com/pohly)) [SIG Architecture, CLI, Instrumentation, Node and Testing]. The PR linked is merged in v1.26: kubernetes/kubernetes#112120

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 22, 2022
@jsturtevant
Copy link
Contributor

thanks for the links @claudiubelu. looks like the docs need an update

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a4099181, fabi200123, jsturtevant

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2022
@k8s-ci-robot k8s-ci-robot merged commit 6ebcb66 into kubernetes-sigs:master Dec 22, 2022
@jsturtevant jsturtevant mentioned this pull request Dec 22, 2022
Closed
@jsturtevant
Copy link
Contributor

created kubernetes/website#38599 to track updating the docs

@a4099181 a4099181 deleted the wip/kubelet26 branch December 23, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claudiubelu claudiubelu claudiubelu left review comments

@fabi200123 fabi200123 fabi200123 approved these changes

@ddebroy ddebroy Awaiting requested review from ddebroy

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

Assignees

@claudiubelu claudiubelu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@a4099181 @jsturtevant @fabi200123 @claudiubelu @k8s-ci-robot